New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#49 Set Stripe prorate option on subscription save #74

Merged
merged 1 commit into from Jan 7, 2015

Conversation

Projects
None yet
3 participants
@hanchang
Contributor

hanchang commented Oct 15, 2014

Apologies for the omission - this should fix #68.

I've added the proper logic in the processing! method of the Koudoku::Subscription concern so that it passes the config setting for prorating in koudoku.rb.

@samdunne

This comment has been minimized.

Show comment
Hide comment
@samdunne

samdunne Oct 16, 2014

Contributor

This seemed fine when I tested it

Contributor

samdunne commented Oct 16, 2014

This seemed fine when I tested it

@yas4891

This comment has been minimized.

Show comment
Hide comment
@yas4891

yas4891 Oct 16, 2014

Collaborator

@samdunne It didn't work when you updated the credit card data.

Collaborator

yas4891 commented Oct 16, 2014

@samdunne It didn't work when you updated the credit card data.

@samdunne

This comment has been minimized.

Show comment
Hide comment
@samdunne

samdunne Oct 17, 2014

Contributor

We need to implement travis :P

Contributor

samdunne commented Oct 17, 2014

We need to implement travis :P

@yas4891

This comment has been minimized.

Show comment
Hide comment
@yas4891

yas4891 Oct 17, 2014

Collaborator

@samdunne We need owner level access for that (or I am too stupid).
I tried it, but didn't see the repo in travis.

Collaborator

yas4891 commented Oct 17, 2014

@samdunne We need owner level access for that (or I am too stupid).
I tried it, but didn't see the repo in travis.

@hanchang

This comment has been minimized.

Show comment
Hide comment
@hanchang

hanchang Oct 19, 2014

Contributor

Yeah, I believe Andrew has to set up the Travis account, but afterwards
anyone with write permissions to the repo can configure it using the
.travis.yml config.

On Fri, Oct 17, 2014 at 1:48 AM, yas4891 notifications@github.com wrote:

@samdunne https://github.com/samdunne We need owner level access for
that (or I am too stupid).
I tried it, but didn't see the repo in travis.


Reply to this email directly or view it on GitHub
#74 (comment).

Contributor

hanchang commented Oct 19, 2014

Yeah, I believe Andrew has to set up the Travis account, but afterwards
anyone with write permissions to the repo can configure it using the
.travis.yml config.

On Fri, Oct 17, 2014 at 1:48 AM, yas4891 notifications@github.com wrote:

@samdunne https://github.com/samdunne We need owner level access for
that (or I am too stupid).
I tried it, but didn't see the repo in travis.


Reply to this email directly or view it on GitHub
#74 (comment).

yas4891 added a commit that referenced this pull request Jan 7, 2015

Merge pull request #74 from hanchang/prorate
#49 Set Stripe prorate option on subscription save

@yas4891 yas4891 merged commit 9e73e64 into andrewculver:master Jan 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment