Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison test when qmake returns "**Unknown**" #29

Closed
wants to merge 1 commit into from
Closed

Fix comparison test when qmake returns "**Unknown**" #29

wants to merge 1 commit into from

Conversation

hawson
Copy link

@hawson hawson commented Oct 9, 2013

When running df-lnp-installer.sh for the first time, I get this error:

[~/df-lnp-installer]$ ./df-lnp-installer.sh
Checking for dependencies...
./df-lnp-installer.sh: line 107: [: Unknown: integer expression expected

Where should Dwarf Fortress be installed? [/home/jbecker/bin/Dwarf Fortress]: ^C
[...]

This comes from the output of "qmake -query QT_VERSION", which can return the string "Unknown". This isn't valid for comparing with "-eq", since that requires numbers, and not strings.

@andrewd18
Copy link
Owner

Change made as part of 0.4.0-dev branch. See 9a46dfa

@andrewd18 andrewd18 closed this Oct 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants