Ostinato should use absolute importing. #19

Closed
d0ugal opened this Issue May 23, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@d0ugal

d0ugal commented May 23, 2012

For example;

https://github.com/andrewebdev/django-ostinato/blob/master/ostinato/statemachine/models.py#L6

A global package called "managers" would cause a conflict (and this will break in python 3 when we get there ;) )

Should probably be changed to one of;

from __future__ import absolute_import

from .managers import StateMachineManager

Or

from ostinato.statemachine managers import StateMachineManager

I've not checked to see how often this occurs.

@andrewebdev

This comment has been minimized.

Show comment Hide comment
@andrewebdev

andrewebdev May 23, 2012

Owner

The ostinato.statemachine app is due to be completly rewritten. The aimed release for this is 0.8. You can track the tickets and stories for this here: https://www.pivotaltracker.com/projects/417365

Will take into account absolute imports when doing that rewrite :).

Owner

andrewebdev commented May 23, 2012

The ostinato.statemachine app is due to be completly rewritten. The aimed release for this is 0.8. You can track the tickets and stories for this here: https://www.pivotaltracker.com/projects/417365

Will take into account absolute imports when doing that rewrite :).

@d0ugal

This comment has been minimized.

Show comment Hide comment
@d0ugal

d0ugal May 23, 2012

Cool, thanks

d0ugal commented May 23, 2012

Cool, thanks

@d0ugal d0ugal closed this May 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment