Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Half-white mana symbol missing? #6

Closed
erg opened this issue Nov 26, 2015 · 2 comments
Closed

Half-white mana symbol missing? #6

erg opened this issue Nov 26, 2015 · 2 comments
Assignees
Labels
enhancement Update to web package needs info Can't start, need info

Comments

@erg
Copy link
Contributor

erg commented Nov 26, 2015

Apologies if you have it already, but there's an Unhinged card called Little Girl that has a half-white symbol.

http://gatherer.wizards.com/Pages/Card/Details.aspx?multiverseid=74257

Awesome font, thanks for the hard work!

@andrewgioia
Copy link
Owner

andrewgioia commented Dec 2, 2015

Nice! I didn't have it already and never knew about it. I just added a small change to enable half symbols, though it's not ideal as it requires a wrapping span:

<span class="ms-half">
    <i class="ms ms-w ms-cost"></i>
</span>

You can see the example in the index.html file.

I'm going to tinker around to see if it's possible to do it within the <i>'s class list.

@andrewgioia andrewgioia added the enhancement Update to web package label Dec 2, 2015
@andrewgioia andrewgioia self-assigned this Dec 2, 2015
@andrewgioia andrewgioia added the needs info Can't start, need info label Sep 23, 2016
@andrewgioia
Copy link
Owner

Finally closing this one out! I can't imagine this was even being used but v1.4.1 now has a single-element fix for this, without the need for a wrapper class!

<i class="ms ms-w ms-half ms-cost"></i>

The old method with a span is still supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Update to web package needs info Can't start, need info
Projects
None yet
Development

No branches or pull requests

2 participants