command observers log commands which fail to execute correctly

andrewk · Feb 17, 2015 · 7fc5ca5 · 7fc5ca5
1 parent 479a210
commit 7fc5ca5
Showing 1 changed file with 18 additions and 4 deletions.
diff --git a/lib/endpoint.js b/lib/endpoint.js
@@ -58,7 +58,7 @@ Endpoint.prototype.write = function(value) {
       catch(e => {
         log.error({
           'source': this.toString(),
-          'message': 'Write command failed',
+          'message': 'Write failed',
           'data': value
         });
         reject(new Error('Hardware failure'));
@@ -76,7 +76,7 @@ Endpoint.prototype.read = function() {
       catch(e => {
         log.error({
           'source':  this.toString(),
-          'message': 'Read command failed',
+          'message': 'Read failed',
           'data': null
         });
         reject(new Error('Hardware failure'));
@@ -92,9 +92,23 @@ Endpoint.prototype.createCommandObserver = function() {
       }
 
       if (command.instruction.type === 'write') {
-        this.write(command.instruction.value);
+        this.write(command.instruction.value).
+          catch(e => {
+            log.error({
+              'source':  'command:' + this,
+              'message': 'Command failed',
+              'data': command
+            });
+          });
       } else if (command.instruction.type === 'read') {
-        this.read();
+        this.read().
+          catch(e => {
+            log.error({
+              'source':  'command:' + this,
+              'message': 'Command failed',
+              'data': command
+            });
+          });
       }
     }
   );