This repository has been archived by the owner on Nov 23, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
1 task
fusion2004
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
andrewmcodes
force-pushed
the
config-updates
branch
from
December 14, 2019 16:00
b8dec6b
to
ed4e223
Compare
Just needs some finishing touches on docs and this is ready to go. |
@all-contributors please add @excid3 for review and ideas. |
I've put up a pull request to add @excid3! 🎉 |
andrewmcodes
force-pushed
the
config-updates
branch
from
December 18, 2019 03:18
13e8e4d
to
05fecca
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Description
Add ability to utilize a configuration file for running the action.
Why should this be added
There are too many issues with the current configuration settings. Some of the commands require special syntax, and adding more isn't scalable. With this new API, adding more changes and configurations should be very simple.
This is currently a POC and there are several more changes and refactorings that need to happen but wanted to get this up on a PR so people could see it and comment on it.
Checklist