Skip to content
This repository has been archived by the owner on Nov 23, 2020. It is now read-only.

Configuration File #75

Merged
merged 6 commits into from
Dec 19, 2019
Merged

Configuration File #75

merged 6 commits into from
Dec 19, 2019

Conversation

andrewmcodes
Copy link
Collaborator

Feature

Description

Add ability to utilize a configuration file for running the action.

Why should this be added

There are too many issues with the current configuration settings. Some of the commands require special syntax, and adding more isn't scalable. With this new API, adding more changes and configurations should be very simple.

This is currently a POC and there are several more changes and refactorings that need to happen but wanted to get this up on a PR so people could see it and comment on it.

Checklist

  • My code follows the style guidelines of this project
  • Actions are passing

@andrewmcodes andrewmcodes added the enhancement New feature or request label Dec 10, 2019
@andrewmcodes andrewmcodes added this to the v3.0.0 milestone Dec 10, 2019
@andrewmcodes andrewmcodes self-assigned this Dec 10, 2019
@andrewmcodes andrewmcodes mentioned this pull request Dec 11, 2019
1 task
@andrewmcodes andrewmcodes marked this pull request as ready for review December 11, 2019 02:14
Copy link

@fusion2004 fusion2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@andrewmcodes
Copy link
Collaborator Author

Just needs some finishing touches on docs and this is ready to go.

@andrewmcodes andrewmcodes changed the title Utilize config file Configuration File Dec 18, 2019
@andrewmcodes
Copy link
Collaborator Author

@all-contributors please add @excid3 for review and ideas.

@allcontributors
Copy link
Contributor

@andrewmcodes

I've put up a pull request to add @excid3! 🎉

@andrewmcodes andrewmcodes merged commit e140072 into master Dec 19, 2019
@andrewmcodes andrewmcodes deleted the config-updates branch December 19, 2019 00:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants