Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip on hover on repeat/loop, shuffle and playlist #99

Merged
merged 1 commit into from May 9, 2017

Conversation

Projects
None yet
2 participants
@russellschmidt
Copy link
Contributor

russellschmidt commented May 9, 2017

This is for issue #87.

Offered a slight difference over the PR #88 that was responding to this in that this is a hover out of the HTML flow and will change based on the .active class of the button so the user can see what the keypress will do ("shuffle" vs "shuffle off").

@andrewngu andrewngu merged commit a93c34e into andrewngu:master May 9, 2017

@andrewngu

This comment has been minimized.

Copy link
Owner

andrewngu commented May 9, 2017

Thanks for your work on this 👍

@russellschmidt

This comment has been minimized.

Copy link
Contributor Author

russellschmidt commented May 9, 2017

My first accepted OSS PR! Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.