New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying with Python's temporary file creation. #2

Merged
merged 2 commits into from Feb 5, 2019

Conversation

Projects
None yet
2 participants
@davidcarboni
Copy link
Collaborator

davidcarboni commented Feb 5, 2019

Hi there,

I was reading through the code and it's got a neat simplicity about it - great that it's just a simple file that can be polled by the client - it's hard for that to go wrong, which feels solid.

It's inspired me to have a go at a serverless idea for providing access to all the "extras" like snapshots, artwork, titles, flyers, video snapshots, etc. (https://github.com/davidcarboni/mamecloud - very rough for now). The extras are usually available for download as zip files, so I'm looking at a function to unzip them when I upload them to a bucket, which got me looking at temporary files and folders.

I decided to use your bucket upload code to get me going. Whilst I was looking at that, I spotted the game "title" temp file uses a deterministic name, so I thought I'd send you a pull request since I've just worked out "proper" temp file creation.

I haven't tried to run it so it may not quite work, but let me know what you think!

David

@andrewnicolalde

This comment has been minimized.

Copy link
Owner

andrewnicolalde commented Feb 5, 2019

Hi David,

As you're clearly very interested in helping develop this, I've added you as a full-fledged contributor to this repo, so you should have write access. I'll also merge this PR, though I haven't yet tested it. Please drop me an email at andrew@andrewn.io so we can arrange getting you GCP console access as well.

@andrewnicolalde andrewnicolalde merged commit 267ae99 into andrewnicolalde:master Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment