Fix CMake configurations #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Project CMake configuration should be in the root directory.
Creating build directory within src is weird.
This is a common requirement for all the C++ code in this project. Ideally, this should be set per target.
This seems superfluous.
This is a nasty approach to set compiler flags. It is breaking builds all over the place.
STATUS needs to be in all caps.
This is already done in CMake.
andrewprock
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just enough fixes to get it building on Linux.
Fixes CI build on Travis.
There's more cleanup and best practices to apply.
Hopefully, this is expected to get done gradually.
Fixes #11
Fixes #24
Fixes #41
Closes #33