Ensure that the dependency map is rendered in a deterministic order. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the Reproducible Builds effort [0] I noticed that
browserify-lite generates unreproducible output. I tracked this down to
JSON.stringify not ordering its result default, resulting in output such as:
- "./foo": 2,
- "./bar": 1
+ "./bar": 1,
+ "./foo": 2
This commit sorts the results so that the build is the same each time.
[0] https://reproducible-builds.org/
|
Please let me know if this has solved the problem in the reproducible builds effort downstream (or if there are more patches needed), and I will tag a release. |
|
Hi @andrewrk Making this change in my local copy made, for example, |
|
Done. Cheers |
lamby
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort I noticed that browserify-lite generates unreproducible output. I tracked this down to
JSON.stringifynot ordering its result by default, resulting in output such as:This commit sorts the results so that the build is the same each time.