Permalink
Commits on Aug 5, 2014
  1. fs: fs.readFile should not throw uncaughtException

    JacksonTian committed with indutny Aug 5, 2014
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
  2. dns: fix GetAddrInfo assert

    trevnorris committed Aug 5, 2014
    The method GetAddrInfo() is used by more than just dns.lookup(), and in
    those cases a third argument isn't passed. This caused the following
    check to abort:
    
      assert(args[3]->IsInt32());
    
    Fixes: 4306786 "net: don't prefer IPv4 addresses during resolution"
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Commits on Aug 4, 2014
  1. net: don't prefer IPv4 addresses during resolution

    cjihrig committed with trevnorris May 22, 2014
    Currently the address resolution family defaults to IPv4. Instead remove
    the preference and instead resolve to a family suitable for the host.
    
    Expose the getaddrinfo flags and allow them to be passed.
    
    Add documentation about new flags.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
  2. test: fix test-net-remote-address-port

    misterdjules committed with trevnorris Aug 1, 2014
    Do not use first socket in second socket's connect handler. Probably a
    copy/paste mistake.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
  3. path: isAbsolute() should always return boolean

    threeday0905 committed with trevnorris Aug 4, 2014
    On Windows, path.isAbsolute() returns an empty string on failed cases.
    This forces the return value to always be boolean.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Commits on Aug 2, 2014
  1. process: improve process binding

    JacksonTian committed with indutny Aug 1, 2014
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
  2. test: disable 0-dgram tests on darwin

    indutny committed Aug 2, 2014
    fix #8023
  3. path: fix slice OOB in trim

    luciotato committed with trevnorris Aug 2, 2014
    Internal function trim(arr). 2nd parameter of slice() should be slice's
    end index (not included). Because of function normalize() (called before
    trim()), "start" is always zero so the bug -for now- has no effect, but
    its a bug waiting to happen.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
  4. test: assert cluster.disconnect is async

    sam-github committed with trevnorris Jul 31, 2014
    See nodejs/node-v0.x-archive#8043, test passed on v0.11 already, but this makes the
    test stronger.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Commits on Aug 1, 2014
  1. tls: throw an error, not string

    JacksonTian committed with indutny Aug 1, 2014
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
Commits on Jul 31, 2014
  1. cluster: support options in Worker constructor

    cjihrig committed with indutny Jul 31, 2014
    This commit moves some common Worker code into the constructor
    via support for an options argument.
    
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
  2. Add fast path for simple URL parsing

    gwicke committed with indutny Jul 1, 2014
    This patch adds a fast path for parsing of simple path-only URLs, as commonly
    found in HTTP requests received by a server.
    
    Benchmark results [ms], before / after patch:
    /foo/bar              0.008956   0.000418 (fast path used)
    http://example.com/   0.011426   0.011437 (normal slow path, no change)
    
    In a simple 'ab' benchmark of a single-threaded web server, this patch
    increases the request rate from around 6400 to 7400 req/s.
    
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
  3. Revert "Cluster: fix shared handles on Windows"

    indutny committed Jul 31, 2014
    This reverts commit 4e68a28.
  4. Cluster: fix shared handles on Windows

    orangemocha committed with indutny Jul 24, 2014
    This is the Node side of the fix for Node's cluster module on Windows.
    nodejs#7691
    
    The other required part is
    joyent/libuv#1384
    
    Windows and Unix return certain socket errors (i.e. EADDRINUSE) at
    different times: bind on Windows, and listen on Unix.
    In an effort to hide this difference, libuv on Windows stores such
    errors in the bind_error field of uv_tcp_t, to defer raising it at
    listen time.
    This worked fine except for the case in which a socket is shared in
    a Node cluster and a bind error occurs.
    
    A previous attempt to fix this (
    joyent/libuv@d1e6be1
    nodejs@3da36fe
    ) was flawed becaused in an attempt to relay the error at the JS level
    it caused the master to start accepting connections.
    
    With this new approach, libuv itself is relaying the bind errors,
    providing for a uniform behavior of uv_tcp_listen.
    
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
  5. Revert "repl: fix overwrite for this._prompt"

    indutny committed Jul 31, 2014
    This reverts commit 7166b55.
  6. cluster: test events emit on cluster.worker

    sam-github committed with indutny Jul 28, 2014
    v0.10 and node docs specific that in a worker, the 'message' and 'error'
    event emits on process, and on cluster.worker.
    
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
Commits on Jul 30, 2014
  1. tests: fix internet/test-dns.js

    misterdjules committed with trevnorris Jul 30, 2014
    internet/test-dns.js assumes that ::1 always resolves to "localhost" on
    all platforms. This is not what happens in reality. Some platforms
    resolve it to "ip6-localhost" too. There doesn't seem to be any consensus
    on what's the right thing to do. However, most sane platforms will use
    either one of these two values.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Commits on Jul 29, 2014
  1. repl: fix overwrite for this._prompt

    yorkie committed with indutny Jul 9, 2014
    Signed-off-by: Fedor Indutny <fedor@indutny.com>
  2. Merge remote-tracking branch 'origin/v0.10' into master

    indutny committed Jul 29, 2014
    Conflicts:
    	doc/api/buffer.markdown
    	lib/_stream_readable.js
    	lib/assert.js
    	lib/buffer.js
    	lib/child_process.js
    	lib/http.js
    	lib/string_decoder.js
    	lib/zlib.js
    	node.gyp
    	test/simple/test-buffer.js
    	test/simple/test-https-foafssl.js
    	test/simple/test-stream2-compatibility.js
    	test/simple/test-tls-server-verify.js
  3. buffer: fix sign overflow in `readUIn32BE`

    indutny committed Jul 29, 2014
    `|` operation takes precendence on `+`, which will result in
    `new Buffer('ffffffff', 16).readUInt32BE(0)` returning `-1` instead of
    `ffffffff`.
  4. tests: fix process.kill pid test.

    misterdjules committed with tjfontaine Jul 29, 2014
    Prevent test-process-kill-pid.js tests suite from sending SIGHUP
    to its process group, which was causing the test runner to terminate.
    
    Fix jenkins' jobs for nodejs-master.
    
    Signed-off-by: Timothy J Fontaine <tjfontaine@gmail.com>
Commits on Jul 28, 2014
  1. cluster: enable error/message events using .worker

    cjihrig committed with indutny Jul 25, 2014
    Between 0.11.1 and 0.11.2, the message and error events stopped
    being usable via the cluster.worker object. This commit makes
    them usable again. Closes #7998.
    
    Signed-off-by: Fedor Indutny <fedor@indutny.com>
  2. process: throw TypeError if kill pid not a number

    sam-github committed with indutny Jul 23, 2014
    Currently, invalid usage such as:
    
        process.kill('SIGTERM')
        process.kill(null)
        process.kill(undefined);
    
    all coerce the pid to 0, and signal the current process.
    
    Signed-off-by: Fedor Indutny <fedor@indutny.com>
Commits on Jul 24, 2014
  1. deps: backport 60c316 from v8 trunk

    indutny committed Jul 24, 2014
    Original commit message:
    
        Extend the interceptor setter ASSERT to support the JSGlobalProxy case.
    
        BUG=v8:3463
        LOG=n
        R=dcarney@chromium.org
    
        Review URL: https://codereview.chromium.org/415973004
    
        git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22589 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
    
        Signed-off-by: Fedor Indutny <fedor@indutny.com>
    
    fix #7969
Commits on Jul 23, 2014
  1. querystring: do not add sep for empty array

    cjihrig committed with indutny Jul 19, 2014
    Currently, stringification of an empty array outputs a single
    separator character. This commit causes an empty array to output
    the empty string.
    
    Signed-off-by: Fedor Indutny <fedor@indutny.com>
  2. test: fix test-https-foafssl

    indutny committed Jul 23, 2014
  3. test: fix test-tls-server-verify

    indutny committed Jul 23, 2014
    fix #7963
  4. net: add remoteFamily for socket

    JacksonTian committed with indutny Jul 16, 2014
    Signed-off-by: Fedor Indutny <fedor@indutny.com>
  5. tls: fix to send TLS Alert before socket destroyed

    shigeki committed with indutny Jul 17, 2014
    When TLS Alert is occured in handshake, ClearOut only write it into
    wbio and does not flush to socket. TLS Alert should be written to
    socket with EncOut before socket is destroyed within its error
    callback.
    
    Signed-off-by: Fedor Indutny <fedor@indutny.com>
  6. gyp: fix ARM build

    mmalecki committed with indutny Jul 23, 2014
    According to V8 changelog, `armv7` config variable was replaced by
    `arm_version`, with value either '7', '6' or 'default'.
    
    Detect ARMv7 and ARMv6 CPUs and default to 'default'.
    
    Signed-off-by: Fedor Indutny <fedor@indutny.com>
  7. child_process: do not access stderr when stdio set to 'ignore'

    cjihrig committed with indutny Jul 20, 2014
    Currently, checkExecSyncError() attempts to access the contents
    of stderr. When stdio is set to 'ignore', this causes a crash.
    This commit adds a check on the access of stderr. Closes #7966.
    
    Signed-off-by: Fedor Indutny <fedor@indutny.com>
  8. doc: console.trace takes a message format

    sam-github committed with indutny Jul 19, 2014
    Documentation claimed it accepted a single label argument, as time and
    timeEnd do, which was incorrect.
    
    Signed-off-by: Fedor Indutny <fedor@indutny.com>
  9. src: export additional startup functions

    deanm committed with indutny Jul 18, 2014
    This allows embedders enough control to initialize node, run the
    event loop, and cleanly exit (including calling handlers).
    
    Signed-off-by: Fedor Indutny <fedor@indutny.com>