Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Error SMF #1

Closed
andrewscaya opened this issue Jul 2, 2016 · 14 comments
Closed

[Question] Error SMF #1

andrewscaya opened this issue Jul 2, 2016 · 14 comments
Assignees
Labels
bug
Milestone

Comments

@andrewscaya
Copy link
Owner

@andrewscaya andrewscaya commented Jul 2, 2016

Hello Doug,

I wrote to You last week about problem with attachment in simple mail form. If is possible please look at this problem.
http://autoimpr.webd.pl/strona1/index.php/form
Could not access file: /home/autoimpr/public_html/strona1/skuppojazdow/
I have two fields with attachments - when I try send one attachment I see this error when I send two all is OK.

Regards

Mateusz

@andrewscaya andrewscaya added this to the 1.8.8 milestone Jul 2, 2016
@andrewscaya andrewscaya self-assigned this Jul 2, 2016
@andrewscaya
Copy link
Owner Author

@andrewscaya andrewscaya commented Jul 2, 2016

Trying to reproduce.

@andrewscaya
Copy link
Owner Author

@andrewscaya andrewscaya commented Jul 3, 2016

I have just reproduced the problem.

CONFIRMED BUG. Severity: Minor. Priority: High.

Minor: the defect does not result in the termination and does not damage the usability of the system and the desired results can be easily obtained by working around the defects.

High: the defect must be resolved as soon as possible because the defect is affecting the application (faulty messages to the user : "The requested page can't be found.", and "If difficulties persist, please contact the System Administrator of this site and report the error below. 1- Could not access file: [DIRECTORY PATH: @param:Directory to Save Attachments]".

@andrewscaya andrewscaya added bug and removed help wanted labels Jul 3, 2016
@andrewscaya
Copy link
Owner Author

@andrewscaya andrewscaya commented Jul 3, 2016

Bug Report

Title: Error messages are displayed to the user when leaving some upload fields empty on form submission

Class: Bug

Date: 2016-06-19
Reported By: Mateusz

Product: Joomla, version: 3.5.1
Product: Simple Email Form, version: 1.8.7
Browser: All
URL: http://autoimpr.webd.pl/strona1/index.php/form

Is it reproducible: Yes

Description

If the user does not use all of the upload fields when submitting the form, he will receive faulty messages : "The requested page can't be found.", and "If difficulties persist, please contact the System Administrator of this site and report the error below. 1- Could not access file: [DIRECTORY PATH: @param:Directory to Save Attachments]". Despite these messages, the form is correctly submitted and the files correctly uploaded to the 'Directory to Save Attachments'.

Steps to Produce/Reproduce

Do not use all of the upload fields when submitting the form.

Expected Results

The user should receive a success message.

Actual Results

Faulty messages to the user.

andrewscaya added a commit that referenced this issue Jul 3, 2016
@andrewscaya
Copy link
Owner Author

@andrewscaya andrewscaya commented Jul 4, 2016

Whitebox testing the suggested patch.

andrewscaya added a commit that referenced this issue Jul 4, 2016
…ser when leaving some upload fields empty on form submission.
@andrewscaya
Copy link
Owner Author

@andrewscaya andrewscaya commented Jul 4, 2016

New unit tests have been added to cover the logical possibilities that the patch's code has introduced into the module. The current code coverage is around 30%.

Also, a latent bug was discovered and fixed.

Finally, the code does not pass the PHP 5.3 tests (Joomla's minimum requirement is 5.3.10 and its recommended requirement is 5.6+). We will have to remove 5.3 from the version matrix.

@andrewscaya
Copy link
Owner Author

@andrewscaya andrewscaya commented Jul 4, 2016

Blackbox testing the suggested patch.

andrewscaya added a commit that referenced this issue Jul 5, 2016
…ser when leaving some upload fields empty on form submission.
@andrewscaya
Copy link
Owner Author

@andrewscaya andrewscaya commented Jul 7, 2016

Release 1.8.8 is now frozen. Release candidate is under final review.

@bplight
Copy link

@bplight bplight commented Jul 7, 2016

Hello.Yesterday viewed this bug.
Is it possible to make in upload field settings Required/nonRequired selector?
Awaiting for improved release!
Thanks for your work!

@andrewscaya
Copy link
Owner Author

@andrewscaya andrewscaya commented Jul 8, 2016

Hello bplight,

Thanks for your suggestion. We are including it in our roadmap for version 2.0.0.

Regards,

@bplight
Copy link

@bplight bplight commented Jul 9, 2016

One more suggestion.
Could you please add a prefix to the name of uploaded file?
It`s nessecary for me that files were not overwritten.
Attached file is uploaded with the same name to thr folder.
The prefix may include year_month_date_time.
(I peeped it in chronoforms joomla extention)

@andrewscaya
Copy link
Owner Author

@andrewscaya andrewscaya commented Jul 10, 2016

Hello bplight,

We thank you for your suggestions and we might implement this last one in a future release.

Regards,

@andrewscaya
Copy link
Owner Author

@andrewscaya andrewscaya commented Jul 12, 2016

Version 1.8.8 released.

@bplight
Copy link

@bplight bplight commented Jul 13, 2016

Thanks a lot!
When do you plan to put new release 1.8.8 on your page http://joomla.unlikelysource.org/ ?

@andrewscaya
Copy link
Owner Author

@andrewscaya andrewscaya commented Jul 13, 2016

Hello bplight,

We will make the new release available as soon as possible. The delay is due to technical problems.

Thank you for your interest in the Simple Email Form Module.

Regards,

Repository owner locked and limited conversation to collaborators Jul 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.