File uploaded in spite of wrong captcha #12

Closed
martinbeaudry opened this Issue Jul 23, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@martinbeaudry
Contributor

martinbeaudry commented Jul 23, 2016

Version: 1.8.8a

Bugs with file upload and captcha features:

  1. When a wrong captcha is entered, the file is still uploaded.
  2. User only receives a success message saying that the files have been downloaded if the following two conditions are true:
    • The last file upload button is used (first ones have no effect);
    • The captcha is wrong.

If the captcha is right, no message is sent.

@andrewscaya

This comment has been minimized.

Show comment
Hide comment
@andrewscaya

andrewscaya Jul 23, 2016

Owner

Bug Report

Title: File upload completes successfully despite a wrong captcha being submitted

Class: Bug

Date: 2016-07-22
Reported By: Martin

Product: Joomla, version: 3.5.1
Product: Simple Email Form, version: 1.8.8
Browser: All

Is it reproducible: Yes

Description

  1. When a wrong captcha is entered, the file is still uploaded.
  2. User only receives a success message saying that the files have been downloaded if the following two conditions are true:
    • The last file upload button is used (first ones have no effect);
    • The captcha is wrong.

If the captcha is right, no message is displayed.

Steps to Produce/Reproduce

Submit a file to upload and enter a wrong captcha.

Expected Results

The user should receive a failure message.

Actual Results

File is uploaded, upload success message is displayed and wrong captcha message is also displayed.

Owner

andrewscaya commented Jul 23, 2016

Bug Report

Title: File upload completes successfully despite a wrong captcha being submitted

Class: Bug

Date: 2016-07-22
Reported By: Martin

Product: Joomla, version: 3.5.1
Product: Simple Email Form, version: 1.8.8
Browser: All

Is it reproducible: Yes

Description

  1. When a wrong captcha is entered, the file is still uploaded.
  2. User only receives a success message saying that the files have been downloaded if the following two conditions are true:
    • The last file upload button is used (first ones have no effect);
    • The captcha is wrong.

If the captcha is right, no message is displayed.

Steps to Produce/Reproduce

Submit a file to upload and enter a wrong captcha.

Expected Results

The user should receive a failure message.

Actual Results

File is uploaded, upload success message is displayed and wrong captcha message is also displayed.

@andrewscaya andrewscaya added the bug label Jul 23, 2016

@andrewscaya andrewscaya added this to the 1.8.9 milestone Jul 23, 2016

Repository owner locked and limited conversation to collaborators Jul 23, 2016

@andrewscaya

This comment has been minimized.

Show comment
Hide comment
@andrewscaya

andrewscaya Jul 23, 2016

Owner

Fixed by commit f8a48f6.

Whitebox testing the suggested patch.

Owner

andrewscaya commented Jul 23, 2016

Fixed by commit f8a48f6.

Whitebox testing the suggested patch.

@andrewscaya

This comment has been minimized.

Show comment
Hide comment
@andrewscaya

andrewscaya Jul 23, 2016

Owner

Blackbox testing the suggested patch.

Owner

andrewscaya commented Jul 23, 2016

Blackbox testing the suggested patch.

@andrewscaya

This comment has been minimized.

Show comment
Hide comment
@andrewscaya

andrewscaya Jul 23, 2016

Owner

Release 1.8.9 is now frozen. Release candidate is under final review.

Owner

andrewscaya commented Jul 23, 2016

Release 1.8.9 is now frozen. Release candidate is under final review.

@andrewscaya

This comment has been minimized.

Show comment
Hide comment
@andrewscaya

andrewscaya Jul 23, 2016

Owner

Version 1.8.9 released.

Owner

andrewscaya commented Jul 23, 2016

Version 1.8.9 released.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.