New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting error of missing closing DIV #18

Closed
thonal opened this Issue Mar 20, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@thonal

thonal commented Mar 20, 2017

Hi,

When I tried to validate a website, it failed on the email form saying it was missing a closing div. After some digging I noticed that the missing closing div could be resolved by adding it to line 1587 of
"/modules/mod_simpleemailform/sefv2.modsimpleemailform.php" :

        .......$this->output .= "</table>\n";

        $this->output .= "</form>\n";

# FLS: Added div. error from validator that is was missing!
        $this->output .= "</div>\n";

        if ($this->formTestMode === 'Y') {
            $this->output = htmlspecialchars($thi.....

I don't know if this is a correct 'fix' or a hack to make it work? It does seem that it closes the div opened at line 1529:

        // Present the Email Form.
        $this->output .= !empty($this->formCssClass)
            ? "<div class=\"" . $this->formCssClass . "\">\n"
            : '';

Could you please advise?

Regards,

Thonal

@andrewscaya

This comment has been minimized.

Show comment
Hide comment
@andrewscaya

andrewscaya Mar 21, 2017

Owner

Hello Thonal,

You are absolutely right! The missing 'div' will be added immediately on the develop branch and will be part of the next release scheduled to be published in August 2017.

Many thanks!

Best regards,

Andrew

Owner

andrewscaya commented Mar 21, 2017

Hello Thonal,

You are absolutely right! The missing 'div' will be added immediately on the develop branch and will be part of the next release scheduled to be published in August 2017.

Many thanks!

Best regards,

Andrew

@andrewscaya andrewscaya added this to the 2.1.0 milestone Mar 21, 2017

@andrewscaya andrewscaya self-assigned this Mar 21, 2017

@andrewscaya andrewscaya added the bug label Mar 21, 2017

andrewscaya added a commit that referenced this issue Mar 21, 2017

2017-03-20 AC: Fixes #18 by adding a missing div tag.
Added a closing div tag in the render method of the SEFv2 object.
@andrewscaya

This comment has been minimized.

Show comment
Hide comment
@andrewscaya

andrewscaya Mar 21, 2017

Owner

Bug fix completed - commit #bc977a9.

Owner

andrewscaya commented Mar 21, 2017

Bug fix completed - commit #bc977a9.

Repository owner locked as resolved and limited conversation to collaborators Dec 15, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.