Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to easily modify SEF's rendering by using its internal methods #22

Closed
andrewscaya opened this issue Dec 8, 2017 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@andrewscaya
Copy link
Owner

@andrewscaya andrewscaya commented Dec 8, 2017

When overriding SEF's rendering, it should be possible to have read access to SEF's internal values in order to use PHP to render those values while still having the possibility to easily modify the form's markup. Also, customized rendering should be contained in a separate file in order to avoid deleting the custom code on each upgrade.

Linked to #21.

@andrewscaya andrewscaya added this to the 2.1.0 milestone Dec 8, 2017
@andrewscaya andrewscaya self-assigned this Dec 8, 2017
andrewscaya added a commit that referenced this issue Dec 9, 2017
This commit allows the user to modify the form's markup more easily.
Moreover, a distribution version of a custom default file is added
for convenience.
@andrewscaya
Copy link
Owner Author

@andrewscaya andrewscaya commented Dec 9, 2017

Done.

@andrewscaya andrewscaya closed this Dec 9, 2017
Repository owner locked and limited conversation to collaborators Dec 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.