Use the "simple" jstransform API #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,8 +2,7 @@ | |||
|
|
|||
| var path = require('path'); | |||
| var sourceMap = require('convert-source-map'); | |||
There was a problem hiding this comment.
Seems like it's not used anymore.
|
Thanks for taking a look at the PR. I've removed the unused vars and dependencies. |
andreypopp
added a commit
that referenced
this pull request
Jun 13, 2015
Use the "simple" jstransform API
|
Thanks, published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facebook is in the process of deprecating react-tools in favor of jstransform. In order to use a new feature of FlowType, I needed to update the version of jstransform used by jstransformify.
This PR obviously breaks backwards compatibility, but I wanted to send it out for comments anyway. The "simple" interface is much easier to use than the visitors list interface, especially if you're coming from reactify. Given the deprecation of react-tools, that's likely to be happening a lot in the near future.
If you're OK with this, I'd be happy to take a stab at making a backwards-compatible version. In the meantime, I'll just use my fork.
cc @zpao @jeffmo