Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Don't use readlink to get dirname of install dir #19

Merged
merged 1 commit into from Apr 1, 2013

Conversation

Projects
None yet
3 participants
Contributor

dirkhh commented Feb 15, 2013

If you use the path to the install directory (which seems the "normal" way of
doing things) then the readlink will return nothing and dirname will fail...

Signed-off-by: Dirk Hohndel dirk@hohndel.org

@dirkhh dirkhh Don't use readlink to get dirname of install dir
If you use the path to the install directory (which seems the "normal" way of
doing things) then the readlink will return nothing and dirname will fail...

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
8d1dbd1
Contributor

dirkhh commented Feb 15, 2013

Maybe I just misunderstand how I was supposed to call the tool, but with this simple fix things work for me :-)

mmichaa commented Apr 1, 2013

Thanks! 👍 Works for me too! :-)

@andreyvit andreyvit added a commit that referenced this pull request Apr 1, 2013

@andreyvit andreyvit Merge pull request #19 from dirkhh/fix-readlink
Don't use readlink to get dirname of install dir
16f0ad7

@andreyvit andreyvit merged commit 16f0ad7 into andreyvit:master Apr 1, 2013

Owner

andreyvit commented Apr 1, 2013

Okay, merging this. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment