Allow Ip addresses when using async ip resolving

andris9 · Jan 15, 2014 · 090a3df · 090a3df
1 parent 4b17837
commit 090a3df
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/lib/fetch.js b/lib/fetch.js
@@ -6,7 +6,8 @@ var http = require("http"),
     dns = require('dns'),
     Stream = require("stream").Stream,
     CookieJar = require("./cookiejar").CookieJar,
-    encodinglib = require("encoding");
+    encodinglib = require("encoding"),
+    net = require("net");
 
 exports.FetchStream = FetchStream;
 exports.CookieJar = CookieJar;
@@ -233,20 +234,24 @@ FetchStream.prototype.runStream = function(url){
     }
 
     if (this.options.asyncDnsLoookup) {
-        var dnsCallback = (function (err, adresses){
+        var dnsCallback = (function (err, addresses){
             if (err) {
                 this.emit("error", err);
                 return;
             }
 
             url_data.urloptions.headers['host'] = url_data.urloptions.hostname || url_data.urloptions.host;
-            url_data.urloptions.hostname = adresses[0];
+            url_data.urloptions.hostname = addresses[0];
             url_data.urloptions.host = url_data.urloptions.headers['host'] + (url_data.urloptions.port? ':' + url_data.urloptions.port: '');
 
             this._runStream(url_data, url);
         }).bind(this);
 
-        dns.resolve4(url_data.urloptions.host, dnsCallback);
+        if(net.isIP(url_data.urloptions.host)){
+            dnsCallback(null, [url_data.urloptions.host]);
+        }else{
+            dns.resolve4(url_data.urloptions.host, dnsCallback);
+        }
     } else {
         this._runStream(url_data, url);
     }

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "fetch",
   "description": "Fetch URL contents",
-  "version": "0.3.5",
+  "version": "0.3.6",
   "author": "Andris Reinman",
   "maintainers": [
     "andris <andris@node.ee>"