Skip to content

/ Android-Password-Store

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort by recently used #1031

Merged
merged 16 commits into from Aug 20, 2020
Merged

Sort by recently used #1031

merged 16 commits into from Aug 20, 2020

Conversation

@Dioxo
Copy link
Contributor

@Dioxo Dioxo commented Aug 19, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

📜 Description

I added a new PasswordSortOrder for recently used passwords, saving the time when the password was used and comparing with others.

💡 Motivation and Context

#535

💚 How did you test it?

📝 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

🔮 Next steps

📸 Screenshots / GIFs
Dioxo added 3 commits Aug 19, 2020
@Dioxo
Sort passwords by recently used
89e3899
@Dioxo
reformat
b493d22
@Dioxo
modified CHANGELOG.md
Loading status checks…
95054d3
@Dioxo Dioxo requested review from fmeum, msfjarvis and Skrilltrax as code owners Aug 19, 2020
@Dioxo Dioxo changed the title Feature/sort by recently usedv2 Sort by recently used Aug 19, 2020
@Dioxo
Merge branch 'develop' into feature/sortByRecentlyUsedv2
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6eb1f91
@fmeum
fmeum reviewed Aug 19, 2020
View changes
Copy link
Member

@fmeum fmeum left a comment

Thanks for the v2, this approach looks pretty good to me. Just a few comments.
app/src/main/java/com/zeapo/pwdstore/PasswordFragment.kt Show resolved Hide resolved
app/src/main/java/com/zeapo/pwdstore/PasswordFragment.kt Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@msfjarvis
msfjarvis reviewed Aug 19, 2020
View changes
Copy link
Member

@msfjarvis msfjarvis left a comment

Seems good to me, address Fabian's review comments and I'll merge it after testing. Great job!
CHANGELOG.md Outdated Show resolved Hide resolved
app/src/main/java/com/zeapo/pwdstore/PasswordFragment.kt Show resolved Hide resolved
@Dioxo
restore format CHANGELOG.md
4e8d520
@Dioxo
Copy link
Contributor Author

@Dioxo Dioxo commented Aug 19, 2020

would it be better to save the file path or a hash?
and I also think that if the password/category is modified, then the previous name is saved and it is not modified. I'm going to fix that too.
Dioxo added 4 commits Aug 19, 2020
@Dioxo
added new sharedPreferences file to manage recent password history
fb66a5c
@Dioxo
associate timestamp when rename category
3fc1c38
@Dioxo
associate timestamp when rename password
Loading status checks…
fcf8f31
@Dioxo
reformat
Loading status checks…
5386097
@Dioxo
Copy link
Contributor Author

@Dioxo Dioxo commented Aug 19, 2020 •
edited

I think i included all your reviews and manage the case of renaming category/password
tell me what you think now :) @msfjarvis @FabianHenneke
@fmeum
fmeum reviewed Aug 19, 2020
View changes
Copy link
Member

@fmeum fmeum left a comment

Some more comments, but I'm overall quite happy. Thanks for the contribution!
CHANGELOG.md Outdated Show resolved Hide resolved
app/src/main/java/com/zeapo/pwdstore/PasswordFragment.kt Outdated Show resolved Hide resolved
app/src/main/java/com/zeapo/pwdstore/PasswordFragment.kt Outdated Show resolved Hide resolved
app/src/main/java/com/zeapo/pwdstore/PasswordStore.kt Outdated Show resolved Hide resolved
app/src/main/java/com/zeapo/pwdstore/PasswordStore.kt Show resolved Hide resolved
app/src/main/java/com/zeapo/pwdstore/crypto/PasswordCreationActivity.kt Outdated Show resolved Hide resolved
app/src/main/java/com/zeapo/pwdstore/utils/PasswordRepository.kt
val timeP1 = recentHistory.getString(p1.file.absolutePath)
val timeP2 = recentHistory.getString(p2.file.absolutePath)
when {
timeP1 != null && timeP2 != null -> timeP2.compareTo(timeP1)

This comment has been minimized.

Sign in to view
@fmeum

fmeum Aug 19, 2020
Member

This could be simplified using compareBy and nullsLast, but I could also add that later.

This comment has been minimized.

Sign in to view
@Dioxo

Dioxo Aug 19, 2020
Author Contributor

I'll leave it to you, I have no idea how to use those...
Dioxo and others added 7 commits Aug 19, 2020
@Dioxo @FabianHenneke
Update CHANGELOG.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8d1c984 
Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
@Dioxo @FabianHenneke
Update app/src/main/java/com/zeapo/pwdstore/PasswordFragment.kt
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d82e548 
Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
@Dioxo @FabianHenneke
Update app/src/main/java/com/zeapo/pwdstore/PasswordFragment.kt
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0202940 
Co-authored-by: Fabian Henneke <FabianHenneke@users.noreply.github.com>
@Dioxo
use kotlin edit extension
Loading status checks…
3e83560
@msfjarvis
Add changelog entry correctly
Verified
This commit was signed with a verified signature.
msfjarvis Harsh Shandilya
GPG key ID: 366D7BBAD1031E80 Learn about signing commits
Loading status checks…
82644ec 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Save paths as Base64 hashes
Verified
This commit was signed with a verified signature.
msfjarvis Harsh Shandilya
GPG key ID: 366D7BBAD1031E80 Learn about signing commits
Loading status checks…
5efccf7 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Missed it
Verified
This commit was signed with a verified signature.
msfjarvis Harsh Shandilya
GPG key ID: 366D7BBAD1031E80 Learn about signing commits
Loading status checks…
679c92a 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis msfjarvis added this to the 1.12.0 milestone Aug 20, 2020
@msfjarvis msfjarvis added the feature label Aug 20, 2020
@msfjarvis
msfjarvis approved these changes Aug 20, 2020
View changes
@msfjarvis msfjarvis merged commit cfb42f0 into android-password-store:develop Aug 20, 2020
5 checks passed
5 checks passed
test-pr (23, freeRelease)
Details
test-pr (23, nonFreeRelease)
Details
test-pr (29, freeRelease)
Details
test-pr (29, nonFreeRelease)
Details
WIP Ready for review
Details
@Dioxo
Dioxo reviewed Aug 20, 2020
View changes
Copy link
Contributor Author

@Dioxo Dioxo left a comment

Hey, @msfjarvis I think you missed one here too.
app/src/main/java/com/zeapo/pwdstore/PasswordStore.kt Show resolved Hide resolved
@msfjarvis msfjarvis mentioned this pull request Aug 20, 2020
Merged
4 of 8 tasks complete
@Dioxo Dioxo deleted the Dioxo:feature/sortByRecentlyUsedv2 branch Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum

@msfjarvis msfjarvis

@Skrilltrax Skrilltrax

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Dioxo @fmeum @msfjarvis
You can’t perform that action at this time.