From a111cf579a90a7b84f6221f915564a829a3090e2 Mon Sep 17 00:00:00 2001 From: Fabian Henneke Date: Thu, 27 Aug 2020 10:37:02 +0200 Subject: [PATCH 1/2] Delete HTTPS instead of SSH key password on error --- .../main/java/com/zeapo/pwdstore/git/operation/GitOperation.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/com/zeapo/pwdstore/git/operation/GitOperation.kt b/app/src/main/java/com/zeapo/pwdstore/git/operation/GitOperation.kt index d537ba7f0c..eceb2b50e2 100644 --- a/app/src/main/java/com/zeapo/pwdstore/git/operation/GitOperation.kt +++ b/app/src/main/java/com/zeapo/pwdstore/git/operation/GitOperation.kt @@ -151,7 +151,7 @@ abstract class GitOperation(gitDir: File, internal val callingActivity: Fragment open fun onError(err: Exception) { // Clear various auth related fields on failure callingActivity.getEncryptedPrefs("git_operation").edit { - remove(PreferenceKeys.SSH_KEY_LOCAL_PASSPHRASE) + remove(PreferenceKeys.HTTPS_PASSWORD) } callingActivity.sharedPrefs.edit { remove(PreferenceKeys.SSH_OPENKEYSTORE_KEYID) } d(err) From bccce9e9e0a2619bdcbeefe58b6bcddb67353963 Mon Sep 17 00:00:00 2001 From: Fabian Henneke Date: Thu, 27 Aug 2020 10:50:24 +0200 Subject: [PATCH 2/2] Add CHANGELOG.md entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c375b7ffca..2285ca7f84 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ All notable changes to this project will be documented in this file. - Password creation UI will scroll if it does not fit on the screen - Git server protocol and authentication mode are only updated when explicitly saved +- Delete stored HTTPS password on connection errors (such as failed authentication) ## [1.11.2] - 2020-08-24