Skip to content

/ Android-Password-Store

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update on-boarding UI #1099

Merged
merged 16 commits into from Sep 15, 2020
Merged

Update on-boarding UI #1099

merged 16 commits into from Sep 15, 2020

Conversation

@Skrilltrax
Copy link
Member

@Skrilltrax Skrilltrax commented Sep 14, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

📜 Description

Onboarding UI changes.

💡 Motivation and Context

Our previous onboarding UI was a bunch of dialogs inside a single activity. This new UI makes it easy to extend the onboarding activity to add new features.

💚 How did you test it?

Tested all the onboarding options.

📝 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

🔮 Next steps

📸 Screenshots / GIFs
Skrilltrax added 3 commits Sep 14, 2020
@Skrilltrax
Add onboarding flow from v2
f75b5e8 
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
@Skrilltrax
Minor fixes
Loading status checks…
9cb72b5 
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
@Skrilltrax
Add changelog entry
Loading status checks…
ddcf6ee 
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
@Skrilltrax Skrilltrax requested review from fmeum and msfjarvis as code owners Sep 14, 2020
@Skrilltrax
Copy link
Member Author

@Skrilltrax Skrilltrax commented Sep 14, 2020

I'm following Buffer's package structure here. We should fix all our packages like this once we are ready to push V2.
Skrilltrax added 2 commits Sep 14, 2020
@Skrilltrax
Merge branch 'develop' into onboarding-ui
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
77f1699
@Skrilltrax
Remove old activity from manifest
Loading status checks…
b30d8d6 
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
@msfjarvis
msfjarvis requested changes Sep 14, 2020
View changes
app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
...rc/main/java/com/zeapo/pwdstore/ui/onboarding/fragments/CloneFragment.kt Outdated Show resolved Hide resolved
app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
.../java/com/zeapo/pwdstore/ui/onboarding/fragments/RepoLocationFragment.kt Outdated Show resolved Hide resolved
.../java/com/zeapo/pwdstore/ui/onboarding/fragments/RepoLocationFragment.kt Outdated Show resolved Hide resolved
app/src/main/java/com/zeapo/pwdstore/utils/Extensions.kt Outdated Show resolved Hide resolved
app/src/main/java/com/zeapo/pwdstore/utils/Extensions.kt Outdated Show resolved Hide resolved
app/src/main/java/com/zeapo/pwdstore/utils/Extensions.kt Outdated Show resolved Hide resolved
app/src/main/java/com/zeapo/pwdstore/utils/Extensions.kt Outdated Show resolved Hide resolved
app/src/main/res/layout/fragment_repo_location.xml Outdated Show resolved Hide resolved
Skrilltrax and others added 6 commits Sep 14, 2020
@Skrilltrax
Remove view type prefix from view ids
Loading status checks…
929584c 
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
@Skrilltrax
Review fixes
Loading status checks…
7d7e7c3 
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
@Skrilltrax
Treewide: Reformat code
Loading status checks…
348ef00 
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
@Skrilltrax
Moar review fixes
Loading status checks…
93b1a9c 
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
@msfjarvis
Merge branch 'develop' into onboarding-ui
Verified
This commit was signed with a verified signature.
msfjarvis Harsh Shandilya
GPG key ID: 366D7BBAD1031E80 Learn about signing commits
Loading status checks…
baec537 
* develop:
  Add tentative workaround for dialog crashes and refactor Git-related code (#1100)

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Revert "Treewide: Reformat code"
Verified
This commit was signed with a verified signature.
msfjarvis Harsh Shandilya
GPG key ID: 366D7BBAD1031E80 Learn about signing commits
Loading status checks…
f3360fd 
This reverts commit 348ef00.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Copy link
Member

@msfjarvis msfjarvis commented Sep 15, 2020

Removed reformat commit since it added too many changes to an already big PR, it can go in separately later.
@msfjarvis msfjarvis self-requested a review Sep 15, 2020
msfjarvis added 5 commits Sep 15, 2020
@msfjarvis
onboarding: cleanup OnboardingActivity init
Verified
This commit was signed with a verified signature.
msfjarvis Harsh Shandilya
GPG key ID: 366D7BBAD1031E80 Learn about signing commits
60ca6e9 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Remove unused layout
Verified
This commit was signed with a verified signature.
msfjarvis Harsh Shandilya
GPG key ID: 366D7BBAD1031E80 Learn about signing commits
da2b9ce 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Remove unnecessary ConstraintLayout
Verified
This commit was signed with a verified signature.
msfjarvis Harsh Shandilya
GPG key ID: 366D7BBAD1031E80 Learn about signing commits
9bcab3d 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Shorten animation duration
Verified
This commit was signed with a verified signature.
msfjarvis Harsh Shandilya
GPG key ID: 366D7BBAD1031E80 Learn about signing commits
9a6937e 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
onboarding: use viewBinding extension in fragments
Verified
This commit was signed with a verified signature.
msfjarvis Harsh Shandilya
GPG key ID: 366D7BBAD1031E80 Learn about signing commits
Loading status checks…
4999677 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis msfjarvis added this to the 1.12.0 milestone Sep 15, 2020
@msfjarvis msfjarvis added the feature label Sep 15, 2020
@msfjarvis
msfjarvis approved these changes Sep 15, 2020
View changes
Copy link
Member

@msfjarvis msfjarvis left a comment

Everything appears to work in my testing
@Skrilltrax Skrilltrax merged commit 4ba3b75 into develop Sep 15, 2020
5 checks passed
5 checks passed
test-pr (23, freeDebug)
Details
test-pr (23, nonFreeDebug)
Details
test-pr (29, freeDebug)
Details
test-pr (29, nonFreeDebug)
Details
WIP Ready for review
Details
@Skrilltrax Skrilltrax deleted the onboarding-ui branch Sep 15, 2020
msfjarvis added a commit to Valodim/Android-Password-Store that referenced this pull request Sep 15, 2020
@msfjarvis
Merge branch 'develop' into autofill-subproject
Verified
This commit was signed with a verified signature.
msfjarvis Harsh Shandilya
GPG key ID: 366D7BBAD1031E80 Learn about signing commits
d023ad6 
* develop:
  Update on-boarding UI (android-password-store#1099)
@fmeum
Copy link
Member

@fmeum fmeum commented Sep 24, 2020

While updating the Wiki entries, I noticed that it doesn't seem to be possible anymore to replace an existing SSH key from the on-boarding UI. Should we reintroduce the access to settings or just reset it if the repository is deleted?
@msfjarvis
Copy link
Member

@msfjarvis msfjarvis commented Sep 24, 2020

While updating the Wiki entries, I noticed that it doesn't seem to be possible anymore to replace an existing SSH key from the on-boarding UI. Should we reintroduce the access to settings or just reset it if the repository is deleted?

I'm not a fan of either option but adding a settings option feels like the less-likely-to-be-annoying choice w.r.t. UX.
@fmeum
Copy link
Member

@fmeum fmeum commented Sep 24, 2020

While updating the Wiki entries, I noticed that it doesn't seem to be possible anymore to replace an existing SSH key from the on-boarding UI. Should we reintroduce the access to settings or just reset it if the repository is deleted?

I'm not a fan of either option but adding a settings option feels like the less-likely-to-be-annoying choice w.r.t. UX.

Agreed. @Skrilltrax Is this something you could add before the release? I will update the remaining Wiki entries.
@msfjarvis
Copy link
Member

@msfjarvis msfjarvis commented Sep 24, 2020

While updating the Wiki entries, I noticed that it doesn't seem to be possible anymore to replace an existing SSH key from the on-boarding UI. Should we reintroduce the access to settings or just reset it if the repository is deleted?

I'm not a fan of either option but adding a settings option feels like the less-likely-to-be-annoying choice w.r.t. UX.

Agreed. @Skrilltrax Is this something you could add before the release? I will update the remaining Wiki entries.

He's got a fair bit of stuff going on at work, I'll do it.
@fmeum
Copy link
Member

@fmeum fmeum commented Sep 24, 2020

While updating the Wiki entries, I noticed that it doesn't seem to be possible anymore to replace an existing SSH key from the on-boarding UI. Should we reintroduce the access to settings or just reset it if the repository is deleted?

I'm not a fan of either option but adding a settings option feels like the less-likely-to-be-annoying choice w.r.t. UX.

Agreed. @Skrilltrax Is this something you could add before the release? I will update the remaining Wiki entries.

He's got a fair bit of stuff going on at work, I'll do it.

Thanks! The Wiki entries should now reflect the flow for 1.12.0. I have also made them recommend in-app generation of SSH keys.
@msfjarvis
Copy link
Member

@msfjarvis msfjarvis commented Sep 24, 2020

While updating the Wiki entries, I noticed that it doesn't seem to be possible anymore to replace an existing SSH key from the on-boarding UI. Should we reintroduce the access to settings or just reset it if the repository is deleted?

I'm not a fan of either option but adding a settings option feels like the less-likely-to-be-annoying choice w.r.t. UX.

Agreed. @Skrilltrax Is this something you could add before the release? I will update the remaining Wiki entries.

He's got a fair bit of stuff going on at work, I'll do it.

Thanks! The Wiki entries should now reflect the flow for 1.12.0. I have also made them recommend in-app generation of SSH keys.

The Wiki changes look good, I've created #1119 to add the settings button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfjarvis msfjarvis

@fmeum fmeum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Skrilltrax @msfjarvis @fmeum
You can’t perform that action at this time.