Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on-boarding UI #1099

Merged
merged 16 commits into from Sep 15, 2020
Merged

Update on-boarding UI #1099

merged 16 commits into from Sep 15, 2020

Conversation

@Skrilltrax
Copy link
Member

@Skrilltrax Skrilltrax commented Sep 14, 2020

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

馃摐 Description

Onboarding UI changes.

馃挕 Motivation and Context

Our previous onboarding UI was a bunch of dialogs inside a single activity. This new UI makes it easy to extend the onboarding activity to add new features.

馃挌 How did you test it?

Tested all the onboarding options.

馃摑 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

馃敭 Next steps

馃摳 Screenshots / GIFs

Skrilltrax added 3 commits Sep 14, 2020
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
@Skrilltrax Skrilltrax requested review from fmeum and msfjarvis as code owners Sep 14, 2020
@Skrilltrax
Copy link
Member Author

@Skrilltrax Skrilltrax commented Sep 14, 2020

I'm following Buffer's package structure here. We should fix all our packages like this once we are ready to push V2.

Skrilltrax added 2 commits Sep 14, 2020
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Skrilltrax and others added 6 commits Sep 14, 2020
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
* develop:
  Add tentative workaround for dialog crashes and refactor Git-related code (#1100)

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
This reverts commit 348ef00.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Copy link
Member

@msfjarvis msfjarvis commented Sep 15, 2020

Removed reformat commit since it added too many changes to an already big PR, it can go in separately later.

@msfjarvis msfjarvis self-requested a review Sep 15, 2020
msfjarvis added 5 commits Sep 15, 2020
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis msfjarvis added this to the 1.12.0 milestone Sep 15, 2020
@msfjarvis msfjarvis added the feature label Sep 15, 2020
Copy link
Member

@msfjarvis msfjarvis left a comment

Everything appears to work in my testing

@Skrilltrax Skrilltrax merged commit 4ba3b75 into develop Sep 15, 2020
5 checks passed
5 checks passed
test-pr (23, freeDebug)
Details
test-pr (23, nonFreeDebug)
Details
test-pr (29, freeDebug)
Details
test-pr (29, nonFreeDebug)
Details
WIP Ready for review
Details
@Skrilltrax Skrilltrax deleted the onboarding-ui branch Sep 15, 2020
msfjarvis added a commit to Valodim/Android-Password-Store that referenced this pull request Sep 15, 2020
* develop:
  Update on-boarding UI (android-password-store#1099)
@fmeum
Copy link
Member

@fmeum fmeum commented Sep 24, 2020

While updating the Wiki entries, I noticed that it doesn't seem to be possible anymore to replace an existing SSH key from the on-boarding UI. Should we reintroduce the access to settings or just reset it if the repository is deleted?

@msfjarvis
Copy link
Member

@msfjarvis msfjarvis commented Sep 24, 2020

While updating the Wiki entries, I noticed that it doesn't seem to be possible anymore to replace an existing SSH key from the on-boarding UI. Should we reintroduce the access to settings or just reset it if the repository is deleted?

I'm not a fan of either option but adding a settings option feels like the less-likely-to-be-annoying choice w.r.t. UX.

@fmeum
Copy link
Member

@fmeum fmeum commented Sep 24, 2020

While updating the Wiki entries, I noticed that it doesn't seem to be possible anymore to replace an existing SSH key from the on-boarding UI. Should we reintroduce the access to settings or just reset it if the repository is deleted?

I'm not a fan of either option but adding a settings option feels like the less-likely-to-be-annoying choice w.r.t. UX.

Agreed. @Skrilltrax Is this something you could add before the release? I will update the remaining Wiki entries.

@msfjarvis
Copy link
Member

@msfjarvis msfjarvis commented Sep 24, 2020

While updating the Wiki entries, I noticed that it doesn't seem to be possible anymore to replace an existing SSH key from the on-boarding UI. Should we reintroduce the access to settings or just reset it if the repository is deleted?

I'm not a fan of either option but adding a settings option feels like the less-likely-to-be-annoying choice w.r.t. UX.

Agreed. @Skrilltrax Is this something you could add before the release? I will update the remaining Wiki entries.

He's got a fair bit of stuff going on at work, I'll do it.

@fmeum
Copy link
Member

@fmeum fmeum commented Sep 24, 2020

While updating the Wiki entries, I noticed that it doesn't seem to be possible anymore to replace an existing SSH key from the on-boarding UI. Should we reintroduce the access to settings or just reset it if the repository is deleted?

I'm not a fan of either option but adding a settings option feels like the less-likely-to-be-annoying choice w.r.t. UX.

Agreed. @Skrilltrax Is this something you could add before the release? I will update the remaining Wiki entries.

He's got a fair bit of stuff going on at work, I'll do it.

Thanks! The Wiki entries should now reflect the flow for 1.12.0. I have also made them recommend in-app generation of SSH keys.

@msfjarvis
Copy link
Member

@msfjarvis msfjarvis commented Sep 24, 2020

While updating the Wiki entries, I noticed that it doesn't seem to be possible anymore to replace an existing SSH key from the on-boarding UI. Should we reintroduce the access to settings or just reset it if the repository is deleted?

I'm not a fan of either option but adding a settings option feels like the less-likely-to-be-annoying choice w.r.t. UX.

Agreed. @Skrilltrax Is this something you could add before the release? I will update the remaining Wiki entries.

He's got a fair bit of stuff going on at work, I'll do it.

Thanks! The Wiki entries should now reflect the flow for 1.12.0. I have also made them recommend in-app generation of SSH keys.

The Wiki changes look good, I've created #1119 to add the settings button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.