Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Conversation

@msfjarvis
Copy link
Member

@msfjarvis msfjarvis commented Dec 21, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

📜 Description

Syncs string localisations from Crowdin.

💡 Motivation and Context

Fixes #1254

💚 How did you test it?

Verified that the app correctly builds.

📝 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

🔮 Next steps

Rig up automation for this job and make it run via a cron-backed GitHub Actions job (working on it at https://github.com/msfjarvis/Android-Password-Store/tree/crowdin-sync-automation)

Fixes #1254

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis msfjarvis added A-localisation Area: Localisation of the app C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users P-medium Priority: medium S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Dec 21, 2020
@msfjarvis msfjarvis removed the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Dec 21, 2020
@msfjarvis msfjarvis merged commit 37c8b41 into android-password-store:develop Dec 21, 2020
@msfjarvis msfjarvis deleted the crowdin-sync branch December 21, 2020 06:18
msfjarvis added a commit that referenced this pull request Dec 21, 2020
Fixes #1254

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
(cherry picked from commit 37c8b41)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis msfjarvis added this to the v1.13.2 milestone Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-localisation Area: Localisation of the app C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users P-medium Priority: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Galician (gl) language not inlcuded on v1.13.1

2 participants