This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Refactor biometric preference handling #1374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfjarvis
added
A-UI-UX
Fixes #1371 Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Skrilltrax
approved these changes
Apr 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Inlines biometric configuration into the preference body rather than use unnecessary indirection.
💡 Motivation and Context
Fixes #1371
💚 How did you test it?
Followed the steps in the issue and verified the app does not crash anymore.
📝 Checklist
I added a CHANGELOG entry if applicable