Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate design system to Material You #1532

Conversation

@msfjarvis
Copy link
Member

@msfjarvis msfjarvis commented Nov 3, 2021

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

馃摐 Description

Migrates APS to use Material You themes and components wherever possible, cleaning up hard-coded colors and themes as well as performing various other cleanups in the process.

We also enable support for dynamic colors on API 31 so Android 12 users can have a consistent UI with the rest of their system and Google apps.

馃挕 Motivation and Context

Material You is the next iteration of Material Design and the library ecosystem around it has reached sufficient maturity for us to be able to migrate to it.

馃挌 How did you test it?

Visual verification of all screens.

馃摑 Checklist

  • I formatted the code ./gradlew spotlessApply
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

馃敭 Next steps

  • Dialogs used by our preference library still rely on AppCompat and hence do not respect the new theming/styling changes, being tracked here.
  • Manrope might not be the best font face for the app, I'm open to suggestions.

馃摳 Screenshots / GIFs

Screenshots (light + dark Material You dynamic colors)

screenshot-20211103-164239
screenshot-20211103-164230
screenshot-20211103-164214
screenshot-20211103-164207
screenshot-20211103-164132
screenshot-20211103-164124
screenshot-20211103-164117
screenshot-20211103-164109
screenshot-20211103-163529
screenshot-20211103-163523
screenshot-20211103-163517
screenshot-20211103-163509
screenshot-20211103-163447
screenshot-20211103-163440
screenshot-20211103-163432
screenshot-20211103-163423
screenshot-20211103-163410
screenshot-20211103-163402
screenshot-20211103-163355
screenshot-20211103-163348
screenshot-20211103-163245
screenshot-20211103-163236
screenshot-20211103-163226
screenshot-20211103-163211

Screenshots (new color palette, no dynamic colors)

screenshot-20211103-164430
screenshot-20211103-164425
screenshot-20211103-164421
screenshot-20211103-164415
screenshot-20211103-164404
screenshot-20211103-164357

msfjarvis added 29 commits Nov 3, 2021
@msfjarvis msfjarvis requested a review from as a code owner Nov 3, 2021
@Skrilltrax
Copy link
Member

@Skrilltrax Skrilltrax commented Nov 3, 2021

Damn, the app looks lit af 馃敟

Loading

Copy link
Member

@Skrilltrax Skrilltrax left a comment

Looks pretty good to me 馃憤

Loading

@msfjarvis msfjarvis merged commit 2cf3ddf into android-password-store:develop Nov 3, 2021
3 checks passed
Loading
@msfjarvis msfjarvis deleted the hs/2021-11-01/material3-migration branch Nov 3, 2021
@msfjarvis
Copy link
Member Author

@msfjarvis msfjarvis commented Nov 7, 2021

ModernAndroidPreferences has been updated to allow clients to provide their own dialog builder factory, once the next release happens we'll have consistent M3 dialogs everywhere.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants