Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Conversation

@msfjarvis
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

paths filter is incompatible with necessary checks system since it blocks merges when the workflow is not run, causing an endless stream of pain.

💚 How did you test it?

📝 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code

🔮 Next steps

📸 Screenshots / GIFs

@msfjarvis msfjarvis marked this pull request as ready for review May 23, 2020 07:53
@msfjarvis msfjarvis changed the title github: test dynamic filtering github: Switch to dynamic filtering May 23, 2020
@msfjarvis
Copy link
Member Author

https://github.com/msfjarvis/Android-Password-Store/pull/1 steps get skipped when I only update README and changing gradle.properties correctly starts the full suite of checks

@msfjarvis msfjarvis requested a review from fmeum May 23, 2020 09:43
msfjarvis added 6 commits May 23, 2020 16:12
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
this can stay stuck, we don't care

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Copy link
Member Author

Had to rebase without changes to fix the broken test

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis msfjarvis self-assigned this May 23, 2020
@msfjarvis msfjarvis merged commit 0c45bff into master May 23, 2020
@msfjarvis msfjarvis deleted the actions-fixup branch May 23, 2020 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants