This repository was archived by the owner on Oct 15, 2024. It is now read-only.
BaseGitActivity: always enforce absolute URLs #788
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Always enforce leading slash since relative URLs are not always correct.
💡 Motivation and Context
An example of the case that should work but doesn't is
/mnt/foo/pass-repowith default SSH port will have the leading/resulting in the path becomingmnt/foo/pass-repothat gets resolved as relative from$HOMEwhich is obviously wrong.💚 How did you test it?
Tested manually with the following configuration
$HOME$HOME/mnt//mnt/📝 Checklist
🔮 Next steps
T E S T S!
📸 Screenshots / GIFs