Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Conversation

@msfjarvis
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

📜 Description

Transifex seems to lack the userbase that Crowdin has in terms of translators which
affects the feasibility of keeping our business on it. Migrating to Crowdin allows
more people to contribute to the app, reducing the future chances of issues like
#839 cropping up again. I have elected to start the Crowdin project with no previous
translations because a large chunk of them were straight up outdated or wrong at this
point thanks to our continuous improvements and changes.

💡 Motivation and Context

Transifex is not getting us localization momentum so we'll be giving Crowdin a shot.

📝 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

🔮 Next steps

We should probably also offer users the option of contributing to localization through an in-app preference.

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis msfjarvis added this to the 1.9.0 milestone Jun 16, 2020
Copy link
Member

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take a look at the German translation over at crowdin.

@fmeum fmeum merged commit b410dbf into android-password-store:master Jun 17, 2020
@fmeum
Copy link
Member

fmeum commented Jun 17, 2020

Sorry for merging right away, I believe that crowdin's string.xml is outdated. I'm FabianHenneke there, if you invite me as a manager, I can update it.

@msfjarvis
Copy link
Member Author

Sorry for merging right away, I believe that crowdin's string.xml is outdated. I'm FabianHenneke there, if you invite me as a manager, I can update it.

Yeah I was gonna ask for your username. Sent a manager invite.

@msfjarvis msfjarvis deleted the switch-to-crowdin branch June 17, 2020 06:40
@fmeum
Copy link
Member

fmeum commented Jun 17, 2020

Should we set up crowdin's GitHub integration?

@msfjarvis
Copy link
Member Author

Should we set up crowdin's GitHub integration?

Yeah I think we should, if manager permissions don't let you configure it on Crowdin I'll do it in a few hours. We should probably also either sync our translations to Crowdin or just delete them all and start from scratch.

@fmeum
Copy link
Member

fmeum commented Jun 17, 2020

Should we set up crowdin's GitHub integration?

Yeah I think we should, if manager permissions don't let you configure it on Crowdin I'll do it in a few hours. We should probably also either sync our translations to Crowdin or just delete them all and start from scratch.

I think I can do it, will give it a try now.

msfjarvis added a commit to Dioxo/Android-Password-Store that referenced this pull request Jun 17, 2020
* master:
  Add crowdin.yml (android-password-store#858)
  Migrate to Crowdin for localization (android-password-store#856)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants