This repository was archived by the owner on Nov 14, 2018. It is now read-only.
Add View.setUsageHint() to describe click actions for TalkBack users#483
Closed
ataulm wants to merge 1 commit intoandroid:masterfrom
Closed
Add View.setUsageHint() to describe click actions for TalkBack users#483ataulm wants to merge 1 commit intoandroid:masterfrom
ataulm wants to merge 1 commit intoandroid:masterfrom
Conversation
Contributor
Author
|
This functionality is possible without |
Contributor
Author
|
Is there something I could answer or change to get this merged in? If it's not suitable for this library, could we close the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage hints are used by TalkBack to describe the action that will be triggered on click or long click, e.g.:
"The Matrix... <pause>... Double tap to start playing movie"where
"The Matrix"is the content description and"Double tap to start playing movie"is the usage hint.Without a custom hint set, it will read:
"The Matrix... <pause>... Double tap to activate".Java implementation:
... setUsageHint(movieItemView, "start playing movie", null); } private static void setUsageHint(View view, @Nullable CharSequence clickLabel, @Nullable CharSequence longClickLabel) { ViewCompat.setAccessibilityDelegate( this, new AccessibilityDelegateCompat() { @Override public void onInitializeAccessibilityNodeInfo(View host, AccessibilityNodeInfoCompat info) { super.onInitializeAccessibilityNodeInfo(host, info); if (host.isClickable()) { info.addAction(new AccessibilityNodeInfoCompat.AccessibilityActionCompat(ACTION_CLICK, clickLabel)); } if (host.isLongClickable()) { info.addAction(new AccessibilityNodeInfoCompat.AccessibilityActionCompat(ACTION_LONG_CLICK, longClickLabel)); } } } ); }with Kotlin-ktx:
There are many more combinations of tests I can add but I dunno if it's too much. I am concerned that
View.ktand consequentlyViewTest.ktwill get very large - is there some strategy to mitigate this or is it not considered an issue?On pre-Lollipop, this behaviour is a no-op (handled by
ViewCompat's implementation ofAccessibilityDelegateunder the hood).