From a919f04def619dd016f97062b708be7f7ae063f1 Mon Sep 17 00:00:00 2001
From: XinyueZ <xinyue.zhao@immonet.de>
Date: Mon, 23 Jul 2018 13:23:04 +0200
Subject: [PATCH] Code optimise

- For warnings of lint, IDE
- Add clearFindViewByIdCache() in onDestroy()
---
 .../paging/ui/SearchRepositoriesActivity.kt        | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/app/src/main/java/com/example/android/codelabs/paging/ui/SearchRepositoriesActivity.kt b/app/src/main/java/com/example/android/codelabs/paging/ui/SearchRepositoriesActivity.kt
index 097b145b..dceb733c 100644
--- a/app/src/main/java/com/example/android/codelabs/paging/ui/SearchRepositoriesActivity.kt
+++ b/app/src/main/java/com/example/android/codelabs/paging/ui/SearchRepositoriesActivity.kt
@@ -31,6 +31,7 @@ import android.widget.Toast
 import com.example.android.codelabs.paging.R
 import com.example.android.codelabs.paging.Injection
 import com.example.android.codelabs.paging.model.Repo
+import kotlinx.android.synthetic.clearFindViewByIdCache
 import kotlinx.android.synthetic.main.activity_search_repositories.*
 
 
@@ -58,6 +59,11 @@ class SearchRepositoriesActivity : AppCompatActivity() {
         initSearch(query)
     }
 
+    override fun onDestroy() {
+        super.onDestroy()
+        clearFindViewByIdCache()
+    }
+
     override fun onSaveInstanceState(outState: Bundle) {
         super.onSaveInstanceState(outState)
         outState.putString(LAST_SEARCH_QUERY, viewModel.lastQueryValue())
@@ -78,22 +84,22 @@ class SearchRepositoriesActivity : AppCompatActivity() {
     private fun initSearch(query: String) {
         search_repo.setText(query)
 
-        search_repo.setOnEditorActionListener({ _, actionId, _ ->
+        search_repo.setOnEditorActionListener { _, actionId, _ ->
             if (actionId == EditorInfo.IME_ACTION_GO) {
                 updateRepoListFromInput()
                 true
             } else {
                 false
             }
-        })
-        search_repo.setOnKeyListener({ _, keyCode, event ->
+        }
+        search_repo.setOnKeyListener { _, keyCode, event ->
             if (event.action == KeyEvent.ACTION_DOWN && keyCode == KeyEvent.KEYCODE_ENTER) {
                 updateRepoListFromInput()
                 true
             } else {
                 false
             }
-        })
+        }
     }
 
     private fun updateRepoListFromInput() {