Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc wrappers still don't actually work, remove them #862

Closed
DanAlbert opened this issue Nov 29, 2018 · 0 comments

Comments

@DanAlbert
Copy link
Collaborator

commented Nov 29, 2018

From my comments here: https://stackoverflow.com/a/53535894/632035

The fake GCC wrappers we have that point to Clang can find the linker now, but still won't find the CRT objects since Clang will only search the sysroot for them, and can't do that properly without a versioned target. GCC would search -L directories.

The goal of these was to keep old build scripts working without changes to the command line. Given that a future release (r21? gradle changes haven't landed yet so maybe further out) will remove the $NDK/platforms directory and whatnot to save space, which will break all these use cases anyway. Given that, and that it would probably take a Clang change that we don't actually want to get the wrappers working, we should probably just remove them.

Alternatively, we could have the GCC wrappers select an Android release by default. The user's -L would override so it would get the right libraries, but it would get the wrong CRT objects. I don't think we should do this, but I don't see other ways of getting these working short of undesirable Clang changes (which would have a long enough lead time that they're probably pointless anyway).

@DanAlbert DanAlbert self-assigned this Nov 29, 2018
@DanAlbert DanAlbert added this to the r19 milestone Nov 29, 2018
@DanAlbert DanAlbert added the for-beta2 label Nov 29, 2018
@DanAlbert DanAlbert closed this Nov 30, 2018
disigma pushed a commit to wimal-build/ndk that referenced this issue Feb 22, 2019
These don't work and the intended use case (keeping old build scripts
working) is going to break when we purge the old install locations
anyway.

Test: ./checkbuild.py
Bug: android/ndk#862
Change-Id: I69107451b8c719863f3029b2361bfc90f00ed89c
(cherry picked from commit b6e4b3d)
disigma pushed a commit to wimal-build/ndk that referenced this issue Feb 22, 2019
Test: None
Bug: android/ndk#862
Change-Id: I55c7cb7ee3b0bde0846a464019e853e45630d21c
(cherry picked from commit f3d8d64)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.