Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

Fix crash after restoring defaults.

After restoring defaults in camcorder mode, the indicator
control calls onSharedPreferenceChanged if record location
is on. onSharedPreferenceChanged is also called in the end
of restorePreferences.

With two onSharedPreferenceChanged calls in a row, the first
call notices effects have been disabled, and begins the
effect pipeline teardown in the background thread. Normally,
this would conclude in a few hundred milliseconds, and would
then restart regular preview.

However, with the second call to onSharedPreferenceChanged
coming in right after the first, the method no longer sees
an effect transition in progress (since current and new
effect are equal to none now), and thus just ends up
restarting preview. That attempt at restart runs into the
crash because the main SurfaceView has not yet been released
by the background effects thread.

To fix this, InLineSettingSwitch should not invoke the
listener when updating UI.


Change-Id: I06aca382105455585b633dc63f014a8f71ccadbe
  • Loading branch information...
commit 4da02059e884dbef897f410861329acad96d46d4 1 parent 0107b90
Wu-cheng Li authored
Showing with 3 additions and 0 deletions.
  1. +3 −0  src/com/android/camera/ui/
3  src/com/android/camera/ui/
@@ -57,13 +57,16 @@ public void initialize(ListPreference preference) {
R.string.accessibility_switch, mPreference.getTitle()));
+ @Override
protected void updateView() {
+ mSwitch.setOnCheckedChangeListener(null);
if (mOverrideValue == null) {
mSwitch.setChecked(mIndex == 1);
} else {
int index = mPreference.findIndexOfValue(mOverrideValue);
mSwitch.setChecked(index == 1);
+ mSwitch.setOnCheckedChangeListener(mCheckedChangeListener);

0 comments on commit 4da0205

Please sign in to comment.
Something went wrong with that request. Please try again.