FOR DONUT! Without this, partner builds that run GoogleSearch in a process that does not have android.permission.ACCESS_COARSE_LOCATION will crash when trying to use Google search from the search dialog or the browser address bar. Fixes http://b/issue?id=2132064 Change-Id: I5782978f71f38b76f3439246cb254175b33c7530
Netherlands, the Czech Republic, Austria, Poland, and Germany. This was due to a Donut change to have web search provider handle the dispatching of searches, and these values were accidentally overlooked as being suggestion base urls (not search base urls) despite the (previously-okay) label of 'google_search_base'.
web search intents. Fixes http://b/2020191
…o that the browser can figure out which window to put a new search into.
I took the Google favicon and magnifying glass from EnhancedGoogleSearchProvider. Also: refactors cursor column handling to use named constant. Also: switch to non-deprecated GoogleHttpClient constructor. Also: move intent_action to searchables.xml Fixes http://b/issue?id=1982033 "GoogleSearch has no icon, and sets no suggestion icons"
in global search, but "Google Search" shows up as the name in 'manage applications'.
as was done with EnhancedGoogleSearchProvider. One difference is that if a system does not have GoogleSettingsProvider, we will simply omit the location request for GoogleSearch.
This was done so that the browser can identify them as search requests and add location information to the request if enabled. Also adding internet permission to the manifest as without that it was throwing errors in the debug log infrequently (we need it anyway since this provider accesses the internet for google searches, but in the past it was running inside the acore process so perhaps was not required and this design may have changed now).
- make the suggestion provider specify the intent action web-search - handle web search intent by launching the browser with the google search url Without these changes, GoogleSearch was passing intent web-search to the browser which was forwarding it back to GoogleSearch and nothing happened in the end.
The search dialog & browser are going to use the system default handler for action.WEB_SEARCH and use that for suggestions & launching web searches. This change makes GoogleSearch provider compatible with that model so it can be used for google searches and suggestions. With this change, Google Search also appears as an item in the Web Search providers list in system search settings.
This was done per suggestion from Bjorn as we ran into http://b/1826540, so that GoogleSearch would really act as a fallback and would not clash with other installed global search providers.