Permalink
Browse files

Not able to call a number that isn't saved in contacts, when pressing…

… the call button from messaging app

Bug 5922602

Don't build the options menu until after the visibility of the recipients
editor is determined.

Change-Id: Ie70019808b130f5ac982285a48b537dce60ca914
  • Loading branch information...
1 parent 758276f commit 2a2e37b3cf7d67e837da1786dd677ce5dd2921d4 Tom Taylor committed Jan 26, 2012
Showing with 4 additions and 1 deletion.
  1. +4 −1 src/com/android/mms/ui/ComposeMessageActivity.java
@@ -1814,7 +1814,6 @@ public void initialize(Bundle savedInstanceState, long originalThreadId) {
// Let the working message know what conversation it belongs to
mWorkingMessage.setConversation(mConversation);
- invalidateOptionsMenu();
// Show the recipients editor if we don't have a valid thread. Hide it otherwise.
if (mConversation.getThreadId() <= 0) {
@@ -1830,6 +1829,10 @@ public void initialize(Bundle savedInstanceState, long originalThreadId) {
} else {
hideRecipientEditor();
}
+ invalidateOptionsMenu(); // do after show/hide of recipients editor because the options
+ // menu depends on the recipients, which depending upon the
+ // visibility of the recipients editor, returns a different
+ // value (see getRecipients()).
updateSendButtonState();

0 comments on commit 2a2e37b

Please sign in to comment.