Permalink
Commits on Nov 8, 2012
  1. MMS doesn't scroll

    Bug 7487819
    
    There was a bug where if the list only had a single item, the smooth scroll
    function would bail out early without scrolling. Also, if the last item
    is taller than the size of the list, we always want to scroll, regardless
    of the other conditions.
    
    Change-Id: I9ee4d3977678e577f10f768c987fbd80dc1ff436
    Tom Taylor committed Nov 8, 2012
  2. App doesn't know your pic on initial send

    Bug 7498702
    
    A previous CL to prevent flickering while receiving a new mms caused the
    avatar to not always get updated. This CL fixes the bug and eliminates
    flickering of previous mms items while the DB is getting changed.
    
    Change-Id: Iac41ed42284235e31b0c26b53cc3496c4e21e9da
    Tom Taylor committed Nov 8, 2012
  3. Add message button is not titled in "Messaging widget" under lock screen

    Bug 7497408
    
    Button now reads as "New message button" by the accessibility voice.
    
    Change-Id: Ice5806812fd11c22b72be6c051add453ca0475c2
    Tom Taylor committed Nov 8, 2012
Commits on Nov 6, 2012
  1. Merge "Flickering when MMS received" into jb-mr1-dev

    Tom Taylor committed with Android (Google) Code Review Nov 6, 2012
  2. Merge "MMS doesn't scroll enough on tall list items" into jb-mr1-dev

    Tom Taylor committed with Android (Google) Code Review Nov 6, 2012
  3. MMS doesn't scroll enough on tall list items

    Bug 7487819
    
    When we've got a list item taller than the whole list when the keyboard
    is up, scroll the top of the item off the screen so the bottom of the item
    is visible just above the keyboard.
    
    Change-Id: I746e4883cd9e69ca788742c05f8feacf96a8b771
    Tom Taylor committed Nov 6, 2012
  4. Flickering when MMS received

    Bug 7481394
    
    Don't clear the picture/video attachment when we're rebinding the same
    list item to the same message. Fixes the double flash on send and the
    flickering on receive.
    
    Change-Id: I6a489fead27e81ac07388696c18dd7b0b6f1d89b
    Tom Taylor committed Nov 6, 2012
  5. Fix to hide keyboard jank-free when coming back to MMS with no draft.

    What was happening is that if you loaded a conversation, brought
    up the IME, left, then came back, there was a brief period where the
    window size was still small (leaving room for the IME), then the IME
    would go away and the window size would expand.
    
    Hiding the keyboard in onPause or onStop didn't prevent this. So
    the fix is to extend the hack of delaying loading the draft messages
    to all cases, not just the case where the keyboard is going to be
    shown. This way the window manager settles down before we load
    the content, and everything comes into view in the right place the
    first time.
    
    b/7481258
    
    Change-Id: If2592737bda4d2938fc8fc982724459d3d26fd35
    midodd committed Nov 6, 2012
Commits on Nov 2, 2012
  1. am 6c164d3: am 0bd818f: WRITE_SMS is possible through SMS_RECEIVED in…

    …tent
    
    * commit '6c164d3634b624d2152fed8b294f8b9ba5cf4cf1':
      WRITE_SMS is possible through SMS_RECEIVED intent
    Tom Taylor committed with Android Git Automerger Nov 2, 2012
  2. am 0bd818f: WRITE_SMS is possible through SMS_RECEIVED intent

    * commit '0bd818f8c28e014bbb10f6ad0e9594bc40da1494':
      WRITE_SMS is possible through SMS_RECEIVED intent
    Tom Taylor committed with Android Git Automerger Nov 2, 2012
Commits on Nov 1, 2012
  1. WRITE_SMS is possible through SMS_RECEIVED intent

    Bug 7442369
    
    Don't export TransactionService and SmsReceiverService. Those services
    can only be started internally.
    
    Change-Id: I0e23ca73868ae63cfb419b413e488ecf8eb2361e
    Tom Taylor committed with gcondra Oct 31, 2012
  2. Removing dead API

    Change-Id: I06573f52e39dd440c0f0b8406b043fa39ede7653
    Adam Cohen committed Nov 1, 2012
Commits on Oct 31, 2012
  1. am b7c4364: WRITE_SMS is possible through SMS_RECEIVED intent

    * commit 'b7c4364c750df605a604b066bcd77741bb248aab':
      WRITE_SMS is possible through SMS_RECEIVED intent
    Tom Taylor committed with Android Git Automerger Oct 31, 2012
  2. WRITE_SMS is possible through SMS_RECEIVED intent

    Bug 7442369
    
    Don't export TransactionService and SmsReceiverService. Those services
    can only be started internally.
    
    Change-Id: I0e23ca73868ae63cfb419b413e488ecf8eb2361e
    Tom Taylor committed Oct 31, 2012
Commits on Oct 24, 2012
  1. am d6566e1: Merge "Add more logging for video capture" into jb-mr1-dev

    * commit 'd6566e19836c5671f333d048ba70bec4cda493bb':
      Add more logging for video capture
    Tom Taylor committed with Android Git Automerger Oct 24, 2012
  2. Merge "Add more logging for video capture" into jb-mr1-dev

    Tom Taylor committed with Android (Google) Code Review Oct 24, 2012
Commits on Oct 23, 2012
  1. Add more logging for video capture

    Bug 7400003
    
    Change-Id: Ic18af7b6dfa4255c547d1c3cf8049878b4d5e00c
    Tom Taylor committed Oct 23, 2012
  2. am 874ef88: b/7378607: more tweaks to reduce jank interacting with th…

    …e keyboard.
    
    * commit '874ef885ee3f132491fddb3dee812e6d38660b79':
      b/7378607: more tweaks to reduce jank interacting with the keyboard.
    Wei Huang committed with Android Git Automerger Oct 23, 2012
  3. b/7378607: more tweaks to reduce jank interacting with the keyboard.

    - remove the hack to hide keyboard in activity onPause(). Yay!
    - hide the compose panel in onRestart(), so it doesn't flash when
    we re-enter the activity thru. onRestart(). Show the compose panel
    later when we load messages+draft.
    
    Change-Id: I314e9298b7b4cfc54a4407d2521b70473d70ee30
    Wei Huang committed Oct 23, 2012
  4. am 469db72: Crash trying to save a draft with a picture from the gallery

    * commit '469db72fcf219fd4c60bc9b01c728bdc3e866d40':
      Crash trying to save a draft with a picture from the gallery
    Tom Taylor committed with Android Git Automerger Oct 23, 2012
  5. Crash trying to save a draft with a picture from the gallery

    Bug 7374081
    
    Change the persister api's to accept a HashMap of opened inputStreams
    for the parts. The inputStreams are opened on the UI thread, but the
    actual persisting takes place on a non-UI thread. We only pre-open the
    inputStreams in onStop, before we lose the gallery permission.
    
    Change-Id: I6eaa8a2635201164a80589e7d30b24a6dd60fcc7
    Tom Taylor committed Oct 23, 2012
Commits on Oct 22, 2012
  1. am 6e39c96: b/7390148, b/7392410: fix a couple of issues introduced b…

    …y cl 558d4cc.
    
    * commit '6e39c964b56287aa74a4432b5531499cda3ab09d':
      b/7390148, b/7392410: fix a couple of issues introduced by cl 558d4cc.
    Wei Huang committed with Android Git Automerger Oct 22, 2012
  2. b/7390148, b/7392410: fix a couple of issues introduced by cl 558d4cc.

    b/7390148: when coming back from attaching a photo (or whatever), don't load the draft.
    Loading draft creates a new mWorkingMessage object, whch will clear the
    attachment url and state, obtained in onActivityResult(). I created a new
    member variable 'mShouldLoadDraft', and set it to false in onActivityResult().
    
    b/7392410: when drawing the bottom panel with empty text (so there is less jank), we
    need to remove the onTextChanged listener; otherwise, it will reset
    mWorkingMessage's draft text too from the onTextChanged callback.
    
    Change-Id: I67b2ec700d90bf85caf5a8b3c87cdb9f15273663
    Wei Huang committed Oct 22, 2012
  3. am 9a75d01: b/7386794: fix bad keyboard interaction in MMS.

    * commit '9a75d01f8fa174396e3f1812e7793b58224e069e':
      b/7386794: fix bad keyboard interaction in MMS.
    Wei Huang committed with Android Git Automerger Oct 22, 2012
  4. b/7386794: fix bad keyboard interaction in MMS.

    - I misunderstood the meaning of 'mIsKeyboardOpen' in my previous cl 558d4cc.
    'mIsKeyboardOpen' is always true for soft keyboard. For device with
    HW keyboard, it's true if the keyboard is open.
    
    Reverted back the code for calling onKeyboardStateChanged(). We
    should not be messing with that when the SW keyboard is open or closed.
    
    Change-Id: I27684885a0dbd6edb3cd563c8d52d06099d6d063
    Wei Huang committed Oct 22, 2012
  5. Merge "Import translations. DO NOT MERGE" into jb-mr1-lockscreen-dev

    Baligh Uddin committed with Android (Google) Code Review Oct 22, 2012
  6. Import translations. DO NOT MERGE

    Change-Id: I36dc370a9e908b17f58316a9d31f04ef69d599f1
    Auto-generated-cl: translation import
    Baligh Uddin committed Oct 22, 2012
  7. am 741128e: Positioning of insertion point on sms draft re-launch

    * commit '741128e7649310e41758e4e88d504c11d61c5458':
      Positioning of insertion point on sms draft re-launch
    Tom Taylor committed with Android Git Automerger Oct 22, 2012
  8. Positioning of insertion point on sms draft re-launch

    Bug 7381862
    
    Change-Id: I805f83a3b579b36326ab98623bbd4873cdb025cb
    Tom Taylor committed Oct 22, 2012
Commits on Oct 19, 2012
  1. am 8e44e61: Merge "b/7363553: part 2 of fix keyboard and window layou…

    …t interaction when re-entering ComposeMessageActivity." into jb-mr1-dev
    
    * commit '8e44e61e138f9dff19fec808e6639fab8523d8cb':
      b/7363553: part 2 of fix keyboard and window layout interaction when re-entering ComposeMessageActivity.
    Wei Huang committed with Android Git Automerger Oct 19, 2012
  2. Merge "b/7363553: part 2 of fix keyboard and window layout interactio…

    …n when re-entering ComposeMessageActivity." into jb-mr1-dev
    Wei Huang committed with Android (Google) Code Review Oct 19, 2012
  3. am 9f12dda: Merge "Size limit reaches for video recording even before…

    … time lapse from Messaging" into jb-mr1-dev
    
    * commit '9f12dda462847a17c9b9d5f357aaa897b09624b4':
      Size limit reaches for video recording even before time lapse from Messaging
    Tom Taylor committed with Android Git Automerger Oct 19, 2012
  4. Merge "Size limit reaches for video recording even before time lapse …

    …from Messaging" into jb-mr1-dev
    Tom Taylor committed with Android (Google) Code Review Oct 19, 2012
Commits on Oct 18, 2012
  1. b/7363553: part 2 of fix keyboard and window layout interaction when …

    …re-entering ComposeMessageActivity.
    
    (this is on top of the cl https://googleplex-android-review.googlesource.com/#/c/242627/4)
    
    The simple idea is to delay loading the message history and draft text until the keyboard
    is shown. The effect is, the compose screen shows blank, keyboard comes up, and the message
    history and draft get displayed.
    
    While the idea is simple, a lot has to be changed in ComposeScreenActivity to make this happen.
    
    - message history query and draft loading were done separately before. Changed to perform
    those actions together. If the keyboard needs to be shown, delay the loading of message+draft
    until we detect the keyboard is shown the first time. The detection is done in the windowMgr
    callback of onSizeChanged(). If we detect the new window height is less than the old height by
    200 pixels, we treat it as "keyboard opened event".
    
    the decision to show keyboard (plus delay message+draft loading) is done in onStart(), but
    we set the window mode in onResume(), and hide the keyboard in onPause(). Hiding the keyboard
    in onPause() makes it less janky to show keyboard when re-entering the activity.
    
    - modify the initialization of the compose view to not display draft text (which can be
    in the compose textfield w/o loading a draft), until the keyboard comes up and we are ready
    to load the message+draft.
    
    - remove conditional draft loading code in onRestart(). We always load the draft in onStart() now.
    loadDraft() can be a no-op if we come back through onRestart(), if the draft is in memory
    already.
    
    - call loadMessageAndDraft in onNewIntent(), which doesn't go thru. onStart() code path.
    
    Change-Id: I2ae953815fe2325b7038a8c647a415275cf77b5f
    Wei Huang committed Oct 18, 2012
  2. am 868f2d2: Merge "MMS creates a new thread when receiver is not in t…

    …he Message thread" into jb-mr1-dev
    
    * commit '868f2d2f4135a2ebeb1acbadfd66403aa91c167e':
      MMS creates a new thread when receiver is not in the Message thread
    Tom Taylor committed with Android Git Automerger Oct 18, 2012