Fix misconceptions about URI permission grants via Intents #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FLAG_GRANT_*_URI_PERMISSION is not used to request URI read/write permissions. Those flags are used to signal the OS that the Intent sender wishes to grant the receiver of an Intent the permission to access content: URIs within the Intent. The documentation of ACTION_OPEN_DOCUMENT doesn't mention these flags and unconditionally states: > All selected documents are returned to the calling application with persistable read and write permission grants.
They are not supported by the ACTION_OPEN_DOCUMENT_TREE Intent. The intended behavior is how ACTION_OPEN_DOCUMENT_TREE works by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
It's not necessary to add flags to the
ACTION_OPEN_DOCUMENTandACTION_OPEN_DOCUMENT_TREEIntents. They will be ignored.