Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getZoneForLatitude seems to have wrong checks #8

Closed
ndorigatti opened this issue May 29, 2018 · 1 comment
Closed

getZoneForLatitude seems to have wrong checks #8

ndorigatti opened this issue May 29, 2018 · 1 comment
Assignees
Labels
bug
Milestone

Comments

@ndorigatti
Copy link

@ndorigatti ndorigatti commented May 29, 2018

https://github.com/googlesamples/android-sunflower/blob/ee23fbc7608ea99a6fdd008885f0ae09d842dd47/app/src/main/java/com/google/samples/apps/sunflower/utilities/GrowZoneUtil.kt#L38
Looking at the alternatives:
in 21.0..28.0 -> 10
in 28.0..21.0 -> 9
in 35.0..21.0 -> 8
in 42.0..21.0 -> 7
in 49.0..21.0 -> 6
in 56.0..21.0 -> 5
in 63.0..21.0 -> 4
in 70.0..77.0 -> 3

35 to 21 is a subset of 42 to 21, and I'm quite sure you just made a mistake due to copy-paste, so should be:

in 21.0..28.0 -> 10
in 28.0..35.0 -> 9
in 35.0..42.0 -> 8
in 42.0..49.0 -> 7
in 49.0..56.0 -> 6
in 56.0..63.0 -> 5
in 63.0..70.0 -> 4
in 70.0..77.0 -> 3
@tiembo tiembo self-assigned this May 29, 2018
@tiembo tiembo added the bug label May 29, 2018
@tiembo

This comment has been minimized.

Copy link
Collaborator

@tiembo tiembo commented May 29, 2018

Thanks for reporting this. We're addressing this internally.

@tiembo tiembo closed this in 47bcd8f May 31, 2018
@tiembo tiembo added this to the 0.1.1 milestone Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.