Skip to content

Reduce amount of code #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Reduce amount of code #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions app/src/main/kotlin/com/fernandocejas/sample/features/movies/MovieDetailsActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,10 @@ class MovieDetailsActivity : BaseActivity() {
companion object {
private const val INTENT_EXTRA_PARAM_MOVIE = "com.fernandocejas.INTENT_PARAM_MOVIE"

fun callingIntent(context: Context, movie: MovieView): Intent {
val intent = Intent(context, MovieDetailsActivity::class.java)
intent.putExtra(INTENT_EXTRA_PARAM_MOVIE, movie)
return intent
}
fun callingIntent(context: Context, movie: MovieView) =
Intent(context, MovieDetailsActivity::class.java).apply {
putExtra(INTENT_EXTRA_PARAM_MOVIE, movie)
}
}

override fun fragment() = MovieDetailsFragment.forMovie(intent.getParcelableExtra(INTENT_EXTRA_PARAM_MOVIE))
Expand Down
11 changes: 3 additions & 8 deletions app/src/main/kotlin/com/fernandocejas/sample/features/movies/MovieDetailsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ package com.fernandocejas.sample.features.movies

import android.os.Bundle
import android.view.View
import androidx.core.os.bundleOf
import com.fernandocejas.sample.core.platform.BaseFragment
import com.fernandocejas.sample.R
import com.fernandocejas.sample.features.movies.MovieFailure.NonExistentMovie
Expand Down Expand Up @@ -46,14 +47,8 @@ class MovieDetailsFragment : BaseFragment() {
companion object {
private const val PARAM_MOVIE = "param_movie"

fun forMovie(movie: MovieView?): MovieDetailsFragment {
val movieDetailsFragment = MovieDetailsFragment()
movie?.let {
val arguments = Bundle()
arguments.putParcelable(PARAM_MOVIE, it)
movieDetailsFragment.arguments = arguments
}
return movieDetailsFragment
fun forMovie(movie: MovieView?) = MovieDetailsFragment().apply {
arguments = bundleOf(PARAM_MOVIE to movie)
}
}

Expand Down