Fix @ItemClick and parametrized types #627

Merged
merged 2 commits into from Jun 18, 2013

Conversation

Projects
None yet
2 participants
@yDelouis
Contributor

yDelouis commented Jun 12, 2013

This PR fixes the issue #504 implementing things suggested to the PR #570.

@DayS

This comment has been minimized.

Show comment
Hide comment
@DayS

DayS Jun 16, 2013

Contributor

This seems great. But you should add a functional test like these to make sure we don't have any ClassCastException or other things like that :)

Contributor

DayS commented Jun 16, 2013

This seems great. But you should add a functional test like these to make sure we don't have any ClassCastException or other things like that :)

@yDelouis

This comment has been minimized.

Show comment
Hide comment
@yDelouis

yDelouis Jun 17, 2013

Contributor

Test added.

Contributor

yDelouis commented Jun 17, 2013

Test added.

@DayS

This comment has been minimized.

Show comment
Hide comment
@DayS

DayS Jun 18, 2013

Contributor

Ok, seems to work fine. Thanks 👍

Contributor

DayS commented Jun 18, 2013

Ok, seems to work fine. Thanks 👍

DayS added a commit that referenced this pull request Jun 18, 2013

Merge pull request #627 from yDelouis/504_genericType_itemClick
Fix @ItemClick and parametrized types

@DayS DayS merged commit a07a843 into androidannotations:develop Jun 18, 2013

@yDelouis yDelouis deleted the yDelouis:504_genericType_itemClick branch Jun 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment