Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PGS subtitles rendered with border and no fill color #1367

Merged
merged 2 commits into from
May 16, 2024

Conversation

TheBeastLT
Copy link

Since #1006 has seen no activity for some time, I thought I'd apply the commit from the correct base, since this bug is quite annoying and has been there for quite a while

@icbaker icbaker self-assigned this May 13, 2024
@icbaker icbaker self-requested a review May 13, 2024 08:30
@icbaker
Copy link
Collaborator

icbaker commented May 15, 2024

I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks!

SimonHung and others added 2 commits May 16, 2024 10:02
Fix "subtitles rendered with border and no fill color" problem:
moneytoo/Player#413

because '0' means it's an index to the palette table, not an RGBA value of 0
@copybara-service copybara-service bot merged commit a4faf4d into androidx:main May 16, 2024
1 check passed
@androidx androidx locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants