New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freezes Youtube navigation for 5 seconds #15

Closed
peterlaws opened this Issue Jun 1, 2016 · 34 comments

Comments

Projects
None yet
2 participants
@peterlaws

peterlaws commented Jun 1, 2016

When you navigate around Youtube, every link you click gives a delay before the red line at the top appears.... When I disable the extension, no delay...

Is this a known issue?

Chrome v51.0.2704.63m
SafeScript v1.0.7.3

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 1, 2016

Owner

Unfortunately I can't reproduce this, I wonder if it's some sort of conflict with another extension.

What operating system are you using?

Owner

andryou commented Jun 1, 2016

Unfortunately I can't reproduce this, I wonder if it's some sort of conflict with another extension.

What operating system are you using?

@peterlaws

This comment has been minimized.

Show comment
Hide comment
@peterlaws

peterlaws Jun 1, 2016

Win 7 64bit

Just tried disabling my other extensions, same outcome........

I frequent a forum, and I noticed it freezes that too on load.

It's like the tab isn't responding, just not long enough for the usual "kill" popup to appear.... I'm sure it's not that, but it feels like it if you get what I mean.

peterlaws commented Jun 1, 2016

Win 7 64bit

Just tried disabling my other extensions, same outcome........

I frequent a forum, and I noticed it freezes that too on load.

It's like the tab isn't responding, just not long enough for the usual "kill" popup to appear.... I'm sure it's not that, but it feels like it if you get what I mean.

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 2, 2016

Owner

What YouTube-related domains do you have whitelisted?

I have the following whitelisted:

  • youtube.com
  • google.com
  • *.googlevideo.com
  • s.ytimg.com
Owner

andryou commented Jun 2, 2016

What YouTube-related domains do you have whitelisted?

I have the following whitelisted:

  • youtube.com
  • google.com
  • *.googlevideo.com
  • s.ytimg.com
@peterlaws

This comment has been minimized.

Show comment
Hide comment
@peterlaws

peterlaws Jun 2, 2016

All those, yep.

The tab hogs 25% of a CPU compared to 10% with SS disabled.

peterlaws commented Jun 2, 2016

All those, yep.

The tab hogs 25% of a CPU compared to 10% with SS disabled.

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 2, 2016

Owner

Can you try setting "XML HTTP Request Handling" to Disabled and let me know if this has any effect?

Owner

andryou commented Jun 2, 2016

Can you try setting "XML HTTP Request Handling" to Disabled and let me know if this has any effect?

@peterlaws

This comment has been minimized.

Show comment
Hide comment
@peterlaws

peterlaws Jun 2, 2016

Still the same....

BTW, I've been using SS for years without trouble, and since the recent updates (ones where you pop the new notice in a tab), this has happened.......

I assume the Export field is the data for everything? I might actually try and uninstall then reinstall and start fresh.

peterlaws commented Jun 2, 2016

Still the same....

BTW, I've been using SS for years without trouble, and since the recent updates (ones where you pop the new notice in a tab), this has happened.......

I assume the Export field is the data for everything? I might actually try and uninstall then reinstall and start fresh.

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 2, 2016

Owner

That is correct! Before you do, please give v1.0.7.4 a try (pushing it soon)

Owner

andryou commented Jun 2, 2016

That is correct! Before you do, please give v1.0.7.4 a try (pushing it soon)

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 2, 2016

Owner

Just letting you know I've pushed v1.0.7.4 and it should auto-update for you soon.

Owner

andryou commented Jun 2, 2016

Just letting you know I've pushed v1.0.7.4 and it should auto-update for you soon.

@peterlaws

This comment has been minimized.

Show comment
Hide comment
@peterlaws

peterlaws Jun 4, 2016

Still same with .4-6......... Will reinstall SS from scratch later today and get back to you.

peterlaws commented Jun 4, 2016

Still same with .4-6......... Will reinstall SS from scratch later today and get back to you.

@peterlaws

This comment has been minimized.

Show comment
Hide comment
@peterlaws

peterlaws Jun 4, 2016

I now think I know why safescript freezes...... If I clear my whitelist...... No freezes..... So, it has to be a parsing issue? tbh, my whitelist has 2,065 sites in..... That said, this doesn't explain why this is recently happening. Maybe you've changed something?

peterlaws commented Jun 4, 2016

I now think I know why safescript freezes...... If I clear my whitelist...... No freezes..... So, it has to be a parsing issue? tbh, my whitelist has 2,065 sites in..... That said, this doesn't explain why this is recently happening. Maybe you've changed something?

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 4, 2016

Owner

Ah that sounds like that's the cause. I did change the parsing recently to support matching expressions.

I'll look into a fix. I'll comment here once I figure out something or have something for you to test, but this is a valid issue. Please keep your whitelist handy :)

Owner

andryou commented Jun 4, 2016

Ah that sounds like that's the cause. I did change the parsing recently to support matching expressions.

I'll look into a fix. I'll comment here once I figure out something or have something for you to test, but this is a valid issue. Please keep your whitelist handy :)

@andryou andryou added the enhancement label Jun 4, 2016

@andryou andryou self-assigned this Jun 4, 2016

andryou added a commit that referenced this issue Jun 5, 2016

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 6, 2016

Owner

Please try v1.0.7.8 and close this issue if resolved, thanks!

Owner

andryou commented Jun 6, 2016

Please try v1.0.7.8 and close this issue if resolved, thanks!

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 6, 2016

Owner

(sorry for the delay in getting v1.0.7.8 to you; it's been "Pending Review" in the Chrome Web Store since I pushed it out 8:45pm eastern yesterday)

Owner

andryou commented Jun 6, 2016

(sorry for the delay in getting v1.0.7.8 to you; it's been "Pending Review" in the Chrome Web Store since I pushed it out 8:45pm eastern yesterday)

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 7, 2016

Owner

I've been refreshing the Developer Dashboard all day to check on the status and I'm happy to announce v1.0.7.8 has been published on the Chrome Web Store within the past half hour.

Owner

andryou commented Jun 7, 2016

I've been refreshing the Developer Dashboard all day to check on the status and I'm happy to announce v1.0.7.8 has been published on the Chrome Web Store within the past half hour.

@peterlaws

This comment has been minimized.

Show comment
Hide comment
@peterlaws

peterlaws Jun 7, 2016

Still a delay...

I've started from scratch, adding to the lists all over again... I'm sure I'm not using most the sites I had in there now anyway.... Cheers for trying and expect a donation soon.

peterlaws commented Jun 7, 2016

Still a delay...

I've started from scratch, adding to the lists all over again... I'm sure I'm not using most the sites I had in there now anyway.... Cheers for trying and expect a donation soon.

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 7, 2016

Owner

Thanks for the update :)

I've created a whitelist with 5,000 entries and I'm working on tweaking the lookup ("A" in the screenshot is the current method). I will incorporate the fastest method into a future update once I'm happy with the speed:

2016-06-07 10_39_55

Owner

andryou commented Jun 7, 2016

Thanks for the update :)

I've created a whitelist with 5,000 entries and I'm working on tweaking the lookup ("A" in the screenshot is the current method). I will incorporate the fastest method into a future update once I'm happy with the speed:

2016-06-07 10_39_55

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 8, 2016

Owner

Coming in v1.0.7.9 (likely tomorrow):

2016-06-08 17_22_17

Owner

andryou commented Jun 8, 2016

Coming in v1.0.7.9 (likely tomorrow):

2016-06-08 17_22_17

@peterlaws

This comment has been minimized.

Show comment
Hide comment
@peterlaws

peterlaws Jun 8, 2016

I'll give it a try.

BTW, hope you got my donation - for your effort on this issue lol

peterlaws commented Jun 8, 2016

I'll give it a try.

BTW, hope you got my donation - for your effort on this issue lol

@peterlaws

This comment has been minimized.

Show comment
Hide comment
@peterlaws

peterlaws Jun 9, 2016

I was hoping I can say this is now fixed, but there's still a delay :/ Even in incognito mode with all other extensions disabled.

The only other tools I use that block web stuff are Ghostery and Ad-Muncher.

peterlaws commented Jun 9, 2016

I was hoping I can say this is now fixed, but there's still a delay :/ Even in incognito mode with all other extensions disabled.

The only other tools I use that block web stuff are Ghostery and Ad-Muncher.

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 9, 2016

Owner

I was hoping the same! Has the delay been improved in any way?

Owner

andryou commented Jun 9, 2016

I was hoping the same! Has the delay been improved in any way?

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 11, 2016

Owner

@peterlaws take a look at #38 and see if that temporary workaround works for you. If it does, you'll be happy to hear that the next release eradicates that/this issue :)

Owner

andryou commented Jun 11, 2016

@peterlaws take a look at #38 and see if that temporary workaround works for you. If it does, you'll be happy to hear that the next release eradicates that/this issue :)

@peterlaws

This comment has been minimized.

Show comment
Hide comment
@peterlaws

peterlaws Jun 11, 2016

Yep, seemed to fix it. Will monitor

peterlaws commented Jun 11, 2016

Yep, seemed to fix it. Will monitor

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 13, 2016

Owner

@peterlaws v1.0.7.11 was just officially released which addresses this issue. Please confirm when you can and close this issue if resolved. Thanks!

Owner

andryou commented Jun 13, 2016

@peterlaws v1.0.7.11 was just officially released which addresses this issue. Please confirm when you can and close this issue if resolved. Thanks!

@peterlaws

This comment has been minimized.

Show comment
Hide comment
@peterlaws

peterlaws Jun 13, 2016

It is now fine, but whatever you did broke the Chromecast Extension, the icon disappears from Youtube/Netflix/Twitch/etc players lol :/

Note: I have to disable the whole extension to get the icon back

peterlaws commented Jun 13, 2016

It is now fine, but whatever you did broke the Chromecast Extension, the icon disappears from Youtube/Netflix/Twitch/etc players lol :/

Note: I have to disable the whole extension to get the icon back

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 13, 2016

Owner

Does anything appear in your blocked resources list when you have ScriptSafe enabled and the icon disappears?

Owner

andryou commented Jun 13, 2016

Does anything appear in your blocked resources list when you have ScriptSafe enabled and the icon disappears?

@peterlaws

This comment has been minimized.

Show comment
Hide comment
@peterlaws

peterlaws Jun 13, 2016

Just the usual blocked stuff, nothing new

peterlaws commented Jun 13, 2016

Just the usual blocked stuff, nothing new

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 14, 2016

Owner

@peterlaws if you could, could you help test a potential fix?

Here are instructions:

  1. Go to the Options page for your current ScriptSafe version
  2. Copy everything in the Export box at the bottom of the page into a text editor
  3. Keep the text editor open or save it to a text file
  4. Download a ZIP of the latest code here: https://github.com/andryou/scriptsafe (click on Clone or download then Download ZIP)
  5. Set up the beta version by skipping to step 2 in the second set of steps on: https://github.com/andryou/scriptsafe/wiki/Frequently-Asked-Questions#how-do-i-install-the-latest-version (make sure you disable the Web Store version)
  6. Open the beta version's Options page, and copy/paste the contents you saved in step 2 into the Import box and click on Import
  7. Test out Youtube/Netflix/Twitch
Owner

andryou commented Jun 14, 2016

@peterlaws if you could, could you help test a potential fix?

Here are instructions:

  1. Go to the Options page for your current ScriptSafe version
  2. Copy everything in the Export box at the bottom of the page into a text editor
  3. Keep the text editor open or save it to a text file
  4. Download a ZIP of the latest code here: https://github.com/andryou/scriptsafe (click on Clone or download then Download ZIP)
  5. Set up the beta version by skipping to step 2 in the second set of steps on: https://github.com/andryou/scriptsafe/wiki/Frequently-Asked-Questions#how-do-i-install-the-latest-version (make sure you disable the Web Store version)
  6. Open the beta version's Options page, and copy/paste the contents you saved in step 2 into the Import box and click on Import
  7. Test out Youtube/Netflix/Twitch
@peterlaws

This comment has been minimized.

Show comment
Hide comment
@peterlaws

peterlaws Jun 14, 2016

Maybe I'm doing it wrong or misunderstanding. I had to do step 2 in the FAQ?

Extract the ZIP file to its own folder anywhere on your computer

Otherwise how do you manually install it via sep 5.

Either way, installed it (has new ID), and am seeing same behaviour re: Chromecast Icon disappeared.
What can I do next.

peterlaws commented Jun 14, 2016

Maybe I'm doing it wrong or misunderstanding. I had to do step 2 in the FAQ?

Extract the ZIP file to its own folder anywhere on your computer

Otherwise how do you manually install it via sep 5.

Either way, installed it (has new ID), and am seeing same behaviour re: Chromecast Icon disappeared.
What can I do next.

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 14, 2016

Owner

Thanks, and you temporarily disabled the web store version as well?

Could you try disabling Block Click-Through Referrer and see if that helps? If not, try unticking .

Owner

andryou commented Jun 14, 2016

Thanks, and you temporarily disabled the web store version as well?

Could you try disabling Block Click-Through Referrer and see if that helps? If not, try unticking .

@peterlaws

This comment has been minimized.

Show comment
Hide comment
@peterlaws

peterlaws Jun 14, 2016

Thanks, and you temporarily disabled the web store version as well?

I uninstalled it.

I tried disabling BCTR and in turn and both disabled, same outcome.....

peterlaws commented Jun 14, 2016

Thanks, and you temporarily disabled the web store version as well?

I uninstalled it.

I tried disabling BCTR and in turn and both disabled, same outcome.....

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 14, 2016

Owner

@peterlaws please repeat the steps in #15 (comment) again, I believe the issue should be fixed (even with BCTR and re-enabled). Please let me know, thank you!

Owner

andryou commented Jun 14, 2016

@peterlaws please repeat the steps in #15 (comment) again, I believe the issue should be fixed (even with BCTR and re-enabled). Please let me know, thank you!

@peterlaws

This comment has been minimized.

Show comment
Hide comment
@peterlaws

peterlaws Jun 14, 2016

Yep, it's back..

What was it JOOI? (nosey)..... I see you added a drop-down to BCTR.

peterlaws commented Jun 14, 2016

Yep, it's back..

What was it JOOI? (nosey)..... I see you added a drop-down to BCTR.

@andryou

This comment has been minimized.

Show comment
Hide comment
@andryou

andryou Jun 14, 2016

Owner

ScriptSafe was also filtering "chrome-extension://" urls that were being injected by Google Cast (as well as LastPass), so I tightened down the scope to just urls that began with "http". And the BCTR drop-down is related to another ticket where it was breaking thumbnail enlarging in Tweetdeck (and I presume other sites as well).

Owner

andryou commented Jun 14, 2016

ScriptSafe was also filtering "chrome-extension://" urls that were being injected by Google Cast (as well as LastPass), so I tightened down the scope to just urls that began with "http". And the BCTR drop-down is related to another ticket where it was breaking thumbnail enlarging in Tweetdeck (and I presume other sites as well).

@peterlaws

This comment has been minimized.

Show comment
Hide comment
@peterlaws

peterlaws Jun 14, 2016

I use LP and TweetDeck but I haven't seen any abnormalities.

Thanks a lot

peterlaws commented Jun 14, 2016

I use LP and TweetDeck but I haven't seen any abnormalities.

Thanks a lot

@peterlaws peterlaws closed this Jun 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment