Add Custom Proxy settings for specialize environment

[rr-paras-patel]

When hipchat-go client runs inside Private DC and need proxy settings to connect internet or particular development environment this settings are necessary

[andybons]

Instead of having a specified ProxyURL, let’s do this:

type Client struct {
  AuthToken string
  BaseURL string
  Timeout  time.Duration
  Transport http.RoundTripper
}

Then instead of using http.Get, you create a client using these properties:

client := &http.Client{
  Transport: c.Transport,
  Timeout:   c.Timeout,
}

and make the request that way.

[rr-paras-patel]

can you be more specific about your comment ? do you want to remove duplicate code and implement single client for all methods (PostMessage, ListRoom) ? or do you wann specify proxy timeout and round-tripper settings ?

[andybons]

• Add the Timeout and Transport properties to the Client struct.
• In each instance where http.Get or http.PostForm is used, do something like this:

    req, err := http.NewRequest(...)
    if err != nil {
        // Handle error
    }
    // Create the HTTP client
    client := &http.Client{
        Transport: c.Transport,
        Timeout:   c.Timeout,
    }

    // Make the request
    res, err := client.Do(req)
    if err != nil {
        // Handle error
    }

[rr-paras-patel]

I have implemented that http.newRequest and client.do for all GET, POST now only one thing i need to ask is
where do we ask for proxy settings from user ? may i make method e.g.

c.Transport := hipchat.SetProxy{"<PROXY_URL>", "<PROXY_PORT>"} 
or handle with 
c := hipchat.NewProxyClient("<AUTH TOKEN>","<PROXY_URL:PROXY_PORT>")

sorry for too many questions i am new to GoLang.

[andybons]

Proxy settings can now be set via setting the Transport property after creating the client. This library shouldn’t care about proxies specifically.

c := hipchat.NewClient("<PUT YOUR AUTH TOKEN HERE>")
c.Transport = &http.Transport{Proxy: http.ProxyURL("<PROXY URL>")}

[rr-paras-patel]

noted 👍

[andybons]

place each property on its own line

return Client {
  AuthToken: authToken,
  ...
}

[andybons]

Still need to do this.

[andybons]

log.Fatalf

[rr-paras-patel]

@andybons so what are we waiting for ?