Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Redis Scripting #12

Open
roja opened this Issue Nov 17, 2011 · 5 comments

Comments

Projects
None yet
4 participants

roja commented Nov 17, 2011

Would it not be a good idea for thoonk to provide Lua scripts which implement each action for the Redis scripting support? This way a given language implementation is simply calling redis with exec commands, which can be made consistent across differing client implementations. This would have 2 advantages:

  1. Minimise the number of network traversals
  2. Provide atomic consistency for commands
  3. Simplify writing a client library

Or am I barking up the wrong tree?

Contributor

legastero commented Nov 17, 2011

That actually is the plan! We want to have that done by December for when scripting lands in a stable Redis release.

Work on Lua scripting has started in the scripting branch.

Member

fritzy commented Nov 18, 2011

Just to be clear, we already have atomic consistency, but there's a lot of work we had to do in Node.js to get that to work right, so it'll be nice to get rid of all of that extra code.

Feel free to contribute to our Lua scripting efforts.

I've added lua scripts for the rest of the job contract on my python branch if you want to copy them across to here:

sjhewitt/thoonk.py@9cf058c

Create, Config and Delete scripts added here:

https://github.com/sjhewitt/thoonk.py/tree/scripting/scripts

Member

fritzy commented Nov 23, 2011

This is soooo awesome! Thank you so much for your contributions! I aim to spend some time going over it and working more on the lua scripting stuff over the Thanksgiving Holiday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment