Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple updates #7

Closed
wants to merge 25 commits into from
Closed

Multiple updates #7

wants to merge 25 commits into from

Conversation

hugomcfonseca
Copy link
Contributor

This PR contains multiple updates to reflect current API endpoints and parameters.

Major improvements were done at:

  • separate component_groups from components and incident_updates from incident to keep same syntax for function names
  • Improved current tests and added new tests for new endpoints and parameters (I am still planning to add new tests for testing other features)
  • Merge querystring parameters to contains all available filters for any endpoint and also parameters that are specific to a given endpoint
  • Others

I know it is an huge pull request, so feel free to ask me anything about it.

Hugo Fonseca and others added 25 commits February 2, 2018 18:45
Updated and created functions to cover current Cachet API (in progress)
9c0f419
Improved multiple existing functions and added functions to new featu…
6b30880 
…res that client was missing
Uniformized functions names and added package to test files
627ed40
Fixed error
683fbb4
Fixed multiple errors (mostly double referencing constraints)
fbc4f36
Fixed errors in JSON tags and struct to Cachet status endpoint
4d6cd81
Multiple fixes
9e847c2
Updating and adding test functions
fba28bc
Fixed metrics test
2e0a09e
@hugomcfonseca
Updated comments and tests and fixed typo in variable name
75448d2
@hugomcfonseca
Added tests and fixed wrong struct in general endpoints
c5a625b
@hugomcfonseca
Fixed tests (still missing new tests & improved structs by HTTP reque…
29b1262 
…st type)
@hugomcfonseca
Merge pull request #1 from hugomcfonseca/functional_tests_fix
8364daa 
Functional tests
Initial commit: added query params for incidents GetAll
ab7ab8e
@hugomcfonseca
Fixed tests and missed import
6a09256
@hugomcfonseca
Fixed first letter of struct to be exported (uppercase)
fb3ece8
@hugomcfonseca
Added available query string fields in all GetAll functions
10b1f7b
Fixed wrong annotation for query string structs
28c4b0b
@hugomcfonseca
Added testing in Schedule and general QueryStrings params
1dd664e
@hugomcfonseca
Temporary workaround to allow nested structs being parsed as querystring
64e4a6e
@hugomcfonseca
Fixed workaround added to support specific and general query strings
0b202ca
Prepared to pull request to origin repo
1de38f2
@hugomcfonseca
Removed ToDo list
583cb1f
@hugomcfonseca
Merge branch 'master' into master
2221863
@hugomcfonseca
Fixed duplicated contents from component_groups.go
2a9acf0
@hugomcfonseca
Copy link
Contributor Author

I am closing this PR for now. I am going to merge my branch with current master and re-create a new PR after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hugomcfonseca