New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reviewers field to ChangeInfo #59

Merged
merged 1 commit into from Jun 28, 2018

Conversation

Projects
None yet
4 participants
@anandsudhir
Contributor

anandsudhir commented Jun 26, 2018

Add Reviewers field to ChangeInfo

from:
https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#change-info

Right now, this is the only field missing from the entities that I need to finish up creating a Gerrit widget on https://github.com/senorprogrammer/wtf

@codecov-io

This comment has been minimized.

codecov-io commented Jun 26, 2018

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   22.59%   22.59%           
=======================================
  Files          21       21           
  Lines        1797     1797           
=======================================
  Hits          406      406           
  Misses       1337     1337           
  Partials       54       54
Impacted Files Coverage Δ
changes.go 16.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5632c7f...78b0a75. Read the comment docs.

@anandsudhir

This comment has been minimized.

Contributor

anandsudhir commented Jun 26, 2018

Although the change is just to add one field, it, unfortunately, looks bigger as I had to add a space on all those lines to ensure that they are aligned.

@anandsudhir anandsudhir referenced this pull request Jun 27, 2018

Merged

Add gerrit widget #228

@andygrunwald andygrunwald merged commit 5ea6031 into andygrunwald:master Jun 28, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 5632c7f...78b0a75
Details
codecov/project 22.59% remains the same compared to 5632c7f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@andygrunwald

This comment has been minimized.

Owner

andygrunwald commented Jun 28, 2018

Thank you :)

@dmitshur

This comment has been minimized.

Collaborator

dmitshur commented Jun 29, 2018

Although the change is just to add one field, it, unfortunately, looks bigger as I had to add a space on all those lines to ensure that they are aligned.

For anyone who doesn't already know, it's possible to add ?w=1 query parameter on GitHub to see the diff ignoring whitespace differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment