Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove distinction between Detector and Image planes #5

Closed
andykee opened this issue Jun 27, 2020 · 1 comment
Closed

Remove distinction between Detector and Image planes #5

andykee opened this issue Jun 27, 2020 · 1 comment

Comments

@andykee
Copy link
Owner

andykee commented Jun 27, 2020

As part of a broader rearchitecting (and hopefully simplification) of the far-field propagation core, I think it's worth considering removing the distinction between Image and Detector planes.

How are Image and Detector related/different: Detector subclasses Image. Both objects have pixelscale and shape attributes, but while they are optional (default to None) for Image, they are required by the Detector constructor.

How Image and Detector are currently used: Including a Detector object in the list of planes provided to propagate is a trigger for using the DFT to perform pupil to image plane propagations. Image does not currently provide any real functionality.

Proposed change: Remove Detector plane and collapse all behavior into Image plane. DFT-based propagations are triggered by Pupil to Image planes where pixelscale is specified.

Additional things to consider:

  • How does this change impact the overall development of an end-to-end propagation strategy
  • Put together a table outlining what happens for various combinations of pupil and image planes
@andykee
Copy link
Owner Author

andykee commented Jun 29, 2020

Resolved in 6beb781

@andykee andykee closed this as completed Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant