Skip to content
This repository

Jul 25, 2011

  1. Kent Sutherland

    Set the level of the update check status window to NSFloatingWindowLe…

    …vel if the host application is background-only.
    authored July 25, 2011

May 02, 2011

  1. Uli Kusterer

    Merge andymatuschak/Sparkle.

    authored May 02, 2011

Dec 04, 2009

  1. Uli Kusterer

    Maybe that makes the progress bar animate? No, it doesn't.

    authored December 04, 2009
  2. Uli Kusterer

    target is an ObjC object, so nil, not NULL.

    authored December 04, 2009
  3. Uli Kusterer

    Merge of changes from SVN repository:

    - Changed NTSynchronousTask to also give the status return value and direct stderror output to the outputData.
    - Changed includes so this builds as part of an app, too, not just as a framework
    - Made sure SUAppcast's dealloc releases some leaked ivars.
    - Added infoURL, extracted from link, that can point to a "more Info" page for download-less URLs
    - Added support for version attribute on item so we can support update notifications that don't include an enclosure (e.g. paid upgrades, or upgrades that would require a system update)
    - Added/improved a few description methods to ease debugging.
    - Added SULog so one can ask for a special log with additional information when there are update issues.
    - Added mayUpdateAndRestart for apps that absolutely, positively can't restart right now (e.g. cuz they're burning a CD and would produce a coaster).
    - Added updaterWillRelaunchApplication delegate method, analogous to the notification. Useful to have app delegate quit helper apps during installation.
    - Made SUBasicUpdateDriver's abortUpdate implicitly retain/autorelease the update driver, because the notification center otherwise releases it and it goes away, causing crashes in superclass's abortUpdate.
    - Merge of SUKeepDownloadOnFailedInstallKey and SUFixedHTMLDisplaySizeKey.
    - Avoid a few warnings about missing prototypes
    - Be paranoid, hdiutil can verify the download again, so let it. Better for internal apps where we turn off DSA checks, too.
    - SUHost has an -installationPath now, independent from the bundlePath, so one can normalize the app name from "MyApp 1.1b4" back to "MyApp" Users assume the file name contains the correct version number when there is one in it. Saves support a few round-trips each time.
    - Be better at threading: Try calling non-thread-safe methods on main thread only, and don't assume delegates know when they need to be thread-safe, call them on main thread where possible.
    - Added a method to put the old copy of the app in the trash. 1.5git changed in this spot, so I didn't actually merge the code that uses it back in yet.
    - Fix version comparison so it doesn't get confused by bracketed build numbers in version strings
    - Make sure cancel button is disabled during extraction, otherwise user would crash.
    - Don't put auto-update window at floating window level. It's huge and can't be switched to background! If you're an NSBGOnly where you need that, turn it on only in that case, but don't generally do such nonsense.
    - Hide release notes view if there aren't any.
    - Test whether we are on dial-up before checking for updates in background. It's not nice to cause (possibly expensive) dial-up periodically.
    - Temporarily comment out DSA complaints for easier testing.
    - Don't store (possibly already invalidated) one-shot NSTimers in an ivar. It's bad style. Retain it instead.
    - Decompress some monster expressions with nested method calls in ternary operators and nested in method calls again.
    - Don't use implicit "id" for params or return types.
    - finish_installation now puts up a progress window, so user knows update is still not finished.
    - Use ThreadSafePreferences (included dummy version that uses regular prefs for projects that don't use ThreadSafePreferences).
    
    - Todo later: Change finish_installation to be prettier.
    authored December 04, 2009

Nov 01, 2009

  1. performed a code review, specifically:

    - changed some #include to #import
    - fixed some NULL -> nil Cocoa coding conventions
    - added new compiler warnings and fixed some warnings they generated
    - check for nil from NSTemporaryDirectory
    - added missing files to unit test and test app targets
    - added xcconfig files for unit test target
    - added @private to some ivars
    - changes some variables from signed to unsigned as appropriate
    - changed from base 2 to base 10 measurements of file size, consistent with both the actual meaning of metric prefixes and Apple's new policy as of 10.6
    - reduced some unneeded copy-paste of code
    - fixed failure to check for null from malloc and unneeded check against null before calling free
    - OSErr was incorrectly used instead of OSStatus
    - added some consts & statics to global strings
    - fixed some issues discovered by static analysis
    - fixed some 64bit issues, mostly related to casting and the use of slightly incorrect types/sizes
    - some dealloc methods were using accessors, changed to access ivars directly, as per Apple guidelines
    - removed old NS_DURING, NS_HANDLER, NS_ENDHANDLER macros
    - fixed a bug where immutable data was being mutated
    - removed all instance of "== YES" as they are dangerous
    - removed some redundant nil checks
    - fixed some leaks
    - conditionally replaced deprecated method usage
    - cleanup CF/NSMakeCollectable usage
    - fixed bug in GC where memory could be collected too early due to lack of strong references when using UTF8String
    - prevent passing null to CFRelease
    authored October 31, 2009

Aug 20, 2009

  1. Andy Matuschak

    Fixes bug #337331: "Status progress still doesn't animate"

    In general, the progress indicator bindings for animate and isDeterminate are totally unreliable. Giving up on them.
    authored August 19, 2009

Aug 20, 2008

  1. Andy Matuschak

    Partial fix for 245277: basic descriptions for some Sparkle classes. …

    …Thanks to Christiaan Hofman for the patch.
    authored August 19, 2008

Jul 30, 2008

  1. Andy Matuschak

    Fixes 252733

    The status window's progress bar now animates even when indeterminate.

Jul 23, 2008

  1. Andy Matuschak

    Fixed 251010

    Fixes from Matt Stevens:
    "For background applications (menu bar, completely UI-less, etc) there are a couple of issues with Sparkle notifications:
    
    - When prompts such as the initial prompt to enable update checking are displayed they can be hidden behind other windows since the background app is not in focus. This can cause problems, as these prompts run modally and can stop the application from functioning without the user knowing why.
    
    - If the update notification window is displayed and the user clicks away to another application, the window disappears and there is no way to get it back since there is no other UI to cause the app to activate. In this case the update should probably operate as a standard window since it is effectively operating as the application's UI."

Jul 16, 2008

  1. Andy Matuschak

    Beginnings of insane SUHost-based refactoring to get rid of NSBundle+…

    …Sparkle. More super-unstable refactorings to come...

Jul 01, 2008

  1. Andy Matuschak

    Fixes 244214

    Made Sparkle display sensible data and use an indeterminate progress bar when the server doesn't report an update's file size.

Jun 29, 2008

  1. Andy Matuschak

    Fixing 241181

    Added a cancel button to the "checking for updates..." dialog.

Jun 21, 2008

  1. Andy Matuschak

    Fixed all setters to eliminate the possibility of accidentally releas…

    …ing the value to be set in the case that [foo setValue:a] is called when [foo value] == a.

May 31, 2008

  1. Andy Matuschak

    Fixes bug 236235.

    Sparkle now gies visual indication that it's checking for updates when hte update's user initiated. ie: it pops up a status controller saying "checking for updates..."
    
    What was SUUserInitiatedUpdateDriver is now SUUIBasedUpdateDriver; SUUserInitiatedUpdateDriver now is a subclass of that, along with SUScheduledUpdateDriver. This is a happy little refactoring that let me remove some redundant code.

Apr 15, 2008

  1. Major refactoring, yay.

    Moved out installation phase to separate classes, separating packages and flat-file installs.
    Made the DMG cleanup less horrifying.
    All-around prettification.
    This may or may not break the world; please let me know.
    authored April 15, 2008

Mar 08, 2008

  1. Removed extraneous KVC will/didChangeValueForKey calls. Thanks, Chris…

    …tiaan Hofman, for pointing out that I am dumb.
    authored March 08, 2008

Mar 07, 2008

  1. Fixed #6: status button now sizes to the localization. Thanks to Chri…

    …stiaan Hofman.
    authored March 07, 2008

Mar 05, 2008

  1. Fixed a potential buffer overrun, made sure to assign to self in -ini…

    …t methods, and made some types more specific; patch courtesy Sean McBride.
    authored March 05, 2008

Feb 14, 2008

  1. Added SUWindowController to reduce duplication of running-in-bundle s…

    …pecial-case code.
    authored February 14, 2008

Jan 14, 2008

  1. Numerous minor changes courtesy Sean McBride. Mostly clarifications.

    authored January 14, 2008

Dec 25, 2007

  1. Improved headers from Charles D. H. Williams.

    authored December 25, 2007

Dec 24, 2007

  1. Fixed up headers to make things easier for those who compile Sparkle …

    …in situ -- thanks for the help, Charles D. H. Williams.
    authored December 24, 2007

Dec 22, 2007

  1. Beware of falling bricks! Huge refactoring commit #1: cleansing Spark…

    …le of the plague that was SUUtilities.
    authored December 22, 2007

Dec 02, 2007

  1. Finally got DMGs working properly on 10.5 through a somewhat less bri…

    …ttle method - ie, no more internetenable. Thanks to Steve Gehrman from CocoaTech.
    
    Also fixed a bug with the host app extension method, the recursive find-the-app-in-the-archive method, and made the extension comparison case insensitive for extraction purposes.
    authored December 02, 2007

Nov 09, 2007

  1. #76 Support for Plug-ins

    authored November 09, 2007

Jul 10, 2007

  1. Holy restructuring, batman! Watch out for falling folders.

    authored July 10, 2007
Something went wrong with that request. Please try again.