Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NSFileManager interface for DMG unarchive only for 10.7+. #183

Merged

Conversation

sinbad
Copy link
Contributor

@sinbad sinbad commented Jun 28, 2012

On 10.6, [NSFileManager copyItemAtPath:toPath:error:] can fail with "Argument list too long" if the app bundle contains too many files. The switch to NSFileManager was only required for 10.7 anyway, 10.6 always worked fine.

For background info, you might want to check this out: https://jira.atlassian.com/browse/SRCTREE-1066

…, [NSFileManager copyItemAtPath:toPath:error:] can fail with "Argument list too long" if the app bundle contains too many files.

The switch to NSFileManager was only required for 10.7 anyway, 10.6 always worked fine.
andymatuschak added a commit that referenced this pull request Jul 6, 2012
Use NSFileManager interface for DMG unarchive only for 10.7+.
@andymatuschak andymatuschak merged commit 118f3c5 into sparkle-project:master Jul 6, 2012
@andymatuschak
Copy link
Contributor

Excellent; thank you. I'm sorry this caused so much trouble!

@sinbad
Copy link
Contributor Author

sinbad commented Jul 6, 2012

A small price to pay for such an excellent library :) Thanks for accepting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants