Skip to content
Commits on Mar 13, 2015
  1. @tysongach

    Update Bitters

    tysongach committed Mar 13, 2015
Commits on Mar 12, 2015
  1. @jferris

    Mention coaching

    jferris committed Mar 12, 2015
Commits on Mar 9, 2015
  1. Enable verify_partial_doubles

    committed Mar 9, 2015
    https://relishapp.com/rspec/rspec-mocks/v/3-0/docs/verifying-doubles/partial-doubles
    
    "When the verify_partial_doubles configuration option is set, the same
    argument and method existence checks that are performed for
    object_double are also performed on partial doubles. You should set
    this unless you have a good reason not to. It defaults to off only for
    backwards compatibility."
Commits on Mar 7, 2015
  1. @croaky

    Update thoughtbot section of README

    croaky committed Mar 7, 2015
    * Include 2015 in the copyright.
    * Update logo to use new HTTPS version.
    * Change header from "Credits" to "About thoughtbot".
    * Move "thank you" to contributors section.
    * Make "About thoughtbot" the last thing in the README,
      with the copyrights grouped closer to the LICENSE information.
    * Link to LICENSE.
    * Make the community link more obvious that we have other projects.
    * Finish with a CTA to hire us.
    * Include `utm_source` codes to improve tracking.
  2. @tute

    Release v0.25.0

    tute committed Mar 7, 2015
    Update NEWS.md.
    
    [ci skip]
  3. @tute

    SVG Travis badge in favor of PNG

    tute committed Mar 7, 2015
    [ci skip]
  4. @ventsislaf @tute

    Configure Active Job queue adapter for test env

    ventsislaf committed with tute Feb 27, 2015
    * Configure ActiveJob's queue adapter to DelayedJob
    * This removes the step to manually configure the `ActiveJob`'s adapter.
    * Use `:inline` queue adapter in test environment to execute the
      background jobs immediately
    * Remove the background jobs template because it's not necessary anymore
    
    [fixes #520]
Commits on Mar 6, 2015
  1. @ventsislaf @jessieay

    Use Ruby 2.2.1

    ventsislaf committed with jessieay Mar 6, 2015
    Ruby 2.2.1 is already available on Heroku and Travis CI.
    
    https://devcenter.heroku.com/changelog-items/619
    http://rubies.travis-ci.org/
  2. @delphaber @jessieay

    Create heroku apps with a valid name

    delphaber committed with jessieay Feb 15, 2015
    Heroku app name could have only letters and dashes. This fix a problem
    with underscores in app name.
Commits on Mar 3, 2015
  1. @tysongach @tute

    Update Bourbon

    tysongach committed with tute Mar 2, 2015
Commits on Mar 2, 2015
  1. @teoljungberg

    Use new hash syntax

    teoljungberg committed Mar 2, 2015
Commits on Feb 20, 2015
  1. @tute

    Add ASSET_HOST to sample.env

    tute committed Feb 14, 2015
    It defaults to `HOST`.
    
    [fixes #491]
Commits on Feb 18, 2015
  1. @pedrosmmoreira

    Set bin/deploy script as executable

    pedrosmmoreira committed Feb 9, 2015
    At the moment, in order to use the deploy script, an user must set as
    executable.
    
    This sets the file as executable after creating it, following the logic
    employed for the `bin/setup` script. It also adds tests for both of
    the files, in order to prevent regression
Commits on Feb 17, 2015
  1. @gylaz @tute

    Set email deliver method to :test for development

    gylaz committed with tute Feb 16, 2015
    `:test` method will not send the email, but instead print it to the logs. This
    will allow faster development cycle, since there is no need to setup
    smtp/sendmail when email is involved.
    
    Closes #516
  2. @aaronagray
Commits on Feb 14, 2015
  1. @delphaber @tute
Commits on Feb 9, 2015
  1. @delphaber

    Use skip_bundle class_option

    delphaber committed Feb 7, 2015
Commits on Feb 4, 2015
  1. @croaky

    v1.24.0

    croaky committed Feb 3, 2015
Commits on Feb 1, 2015
  1. @coding-chimp
Commits on Jan 30, 2015
  1. @croaky

    Refer to Hound in addition to thoughtbot/guides

    croaky committed Jan 27, 2015
    * It's unreasonable to expect contributors to
      read and comprehend thoughtbot/guides.
    * It's reasonable to expect they should fix Hound violations.
    * Shorten a few other sentences.
    * Delete unnecessary words.
    * Move note about Ruby version inside `CONTRIBUTING.md` document.
Commits on Jan 27, 2015
  1. @delphaber @croaky
  2. @mike-burns

    Document how to use the #title helper

    mike-burns committed Jan 21, 2015
    When opening layout.html.erb to change the title, if can be off-putting
    to traverse down a nest of discovery in order to know that one should
    change the title in config/locales/*.yml. Add a note right there so that
    people don't have to hunt.
  3. @delphaber @croaky

    Use new --skip-turbolinks flag

    delphaber committed with croaky Jan 23, 2015
Commits on Jan 26, 2015
  1. @bf4 @croaky

    Faster, more correct gem install

    bf4 committed with croaky Jan 22, 2015
    - About 3x faster when gems are available
    - Does not return false positive when other gems on system have 'bundler' in name
    
    Tested on my 2015 Macbook Pro, Mavericks,
    with RVM and Ruby 2.1.5 running via bash
    
    See details in thoughtbot#497
Commits on Jan 23, 2015
  1. @gabebw

    Tell Heroku to serve static files

    gabebw committed Jan 20, 2015
    By default, Rails 4 will not serve your assets:
    https://devcenter.heroku.com/articles/rails-4-asset-pipeline#serve-assets
    
    We use an environment variable to tell Rails to serve static files:
    
        config.serve_static_files = ENV['RAILS_SERVE_STATIC_FILES'].present?
    
    ..but we were not automatically setting that environment variable on Heroku. Now
    we are.
Commits on Jan 19, 2015
  1. @croaky

    v1.23.0

    croaky committed Jan 19, 2015
  2. @gabebw

    Don't set default_url_options to a string

    gabebw committed Jan 13, 2015
    Before:
    
    config.action_mailer.default_url_options = { host: 'ENV.fetch("HOST")' }
    
    After:
    
    config.action_mailer.default_url_options = { host: ENV.fetch("HOST") }
  3. @gabebw

    Run `rake dev:prime` on CI

    gabebw committed Jan 13, 2015
    Previously, the `dev:prime` task was only available in the development
    environment, while CI runs in the test environment. Because the environments
    didn't match, the `dev:prime` task is never defined in CI, and CI crashes.
    
    We now define the `dev:prime` task in the test environment, because CI should be
    testing whether this part of `bin/setup` runs too.
Commits on Jan 18, 2015
  1. @gabebw

    Turn off Travis email notifications

    gabebw committed Jan 18, 2015
    The documentation gives this as the correct way to turn off build notifications:
    
      notifications:
        email: false
    
    This maps to `{ "notifications" => { "email" => false } }` in Ruby.
    
    We currently set it to:
    
      notifications:
        email:
          - false
    
    This maps to `{ "notifications" => { "email" => [false] } }` (note that `false`
    is in an array). Because of this, Travis does not turn off email notifications.
    
    Docs: http://docs.travis-ci.com/user/notifications/
  2. @gabebw

    Correctly indent config.static_cache_control line

    gabebw committed Jan 13, 2015
    Before:
    
      config.serve_static_files = ENV['RAILS_SERVE_STATIC_FILES'].present?
    config.static_cache_control = "public, max-age=#{1.year.to_i}"
    
    After:
    
      config.serve_static_files = ENV['RAILS_SERVE_STATIC_FILES'].present?
      config.static_cache_control = "public, max-age=#{1.year.to_i}"
Commits on Jan 17, 2015
  1. @gabebw

    Turn off parameter wrapping

    gabebw committed Jan 15, 2015
    With this setting on, Rails will happily turn a POST to the UsersController
    from this:
    
        { name: "Ralph" }
    
    Into this:
    
        { users: { name: "Ralph" }, name: "Ralph" }
    
    This means that `params.require(:user).permit(:name)` will not raise an error, even if the
    developer forgets to nest their parameters inside a top-level `user` key.
    
    It is enabled for JSON by default. This change turns it off for every format.
  2. @gabebw

    Prepend a new line before adding to README

    gabebw committed Jan 13, 2015
    Before:
    
      * [Style](http://github.com/thoughtbot/guides/blob/master/style)
      ## Deploying
    
    ...and it renders "## Deploying" on the same line as the Style link.
    
    After:
    
      * [Style](http://github.com/thoughtbot/guides/blob/master/style)
    
      ## Deploying
Commits on Jan 15, 2015
  1. @gabebw

    gitignore /public/assets

    gabebw committed Jan 10, 2015
    The only files that get put in `/public/assets` are asset files generated from
    `rake assets:precompile`. These files should never be committed since Heroku
    will generate the files for us.
    
    Even without Heroku, these files will change when their source files change, at
    minimum doubling the size of the commit diff without adding any extra
    information.
    
    Or, they won't get regenerated when their source files change, and so will be
    constantly out-of-date.
Commits on Jan 12, 2015
  1. @kylefiedler
  2. @croaky

    v1.22.0

    croaky committed Jan 11, 2015
Something went wrong with that request. Please try again.