New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angel 1.0.0 -> 1.1.0 migration guide #49

Closed
thosakwe opened this Issue Feb 14, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@thosakwe
Member

thosakwe commented Feb 14, 2018

Based on the changelog, up to 1.1.0: https://pub.dartlang.org/packages/angel_framework/versions/1.1.1#-changelog-tab-

Main points:

  • angel_diagnostics is deprecated - instead just pass a Logger and set it as app.logger.
  • Removed AngelFatalError, and subsequently fatalErrorStream.
    • Errors are automatically create 500. Set app.logger to see output.
    • angel_errors is no longer useful.
  • Removed all @deprecated members.
  • Removed @hooked, beforeProcessed, and afterProcessed.
  • Made injections in RequestContext private.
  • Renamed properties in AngelBase to configuration.
  • Added support for pattern matching and other injections via @Parameter()
  • Officially deprecated properties in Angel.
  • Fixed a bug where cached routes would not heed the request method. #173
  • Reworked error handling logic; now, errors will not automatically default to sending JSON.
  • Removed the onController stream from Angel.
  • Controllers now longer use call, which has now been renamed to configureServer.

Aside from these points, there are several things to note.

Migration in itself will be pretty easy to achieve. Plugins and services haven't really changed, it's just the HTTP server itself.

@kingkazuma

This comment has been minimized.

kingkazuma commented Mar 18, 2018

In 1.1.0, Removed Angel.after, before, justBeforeStart, justBeforeStop and fatalErrorStream,
What should I use instead of?

@thosakwe

This comment has been minimized.

Member

thosakwe commented Mar 18, 2018

  1. There is no replacement for before/after. This way, it is easier to keep track of the order request handlers run. responseFinalizers are still in place.
  2. justBeforeStart, justBeforeStop => startupHooks, shutdownHooks
  3. fatalErrorStream is no longer necessary; you can just set app.errorHandler. Fatal errors will be wrapped in a 500 response
@kingkazuma

This comment has been minimized.

kingkazuma commented Mar 19, 2018

emm, So, how should i define global middleware?
Angel.use("/.*", null, (req, res)=> ... ) ?

@thosakwe

This comment has been minimized.

Member

thosakwe commented Mar 19, 2018

app.use((req, res) => ...)

Much cleaner in 1.1.0. 😄

@kingkazuma

This comment has been minimized.

kingkazuma commented Mar 21, 2018

Thanks! : )

@thosakwe thosakwe closed this Jun 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment