Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat query_dsl as part of options rather than query #14

Closed
wants to merge 4 commits into from

Conversation

rubish
Copy link

@rubish rubish commented May 10, 2011

Queries written with query_dsl => false should also use options. The current implementation doesn't allow them. That is, when I do

User.search :sort => [{:weight => "desc"}], 
                   :query => {:match_all => {}},
                   :query_dsl => false,
                   :per_page => 10,
                   :page => 1

even though per_page and page are treated as part of query and are passed to ES resulting in a failing query, however they are options passed to escargot and should not be passed down to elastic search.

PS: there is a failing test, which was failing before I did my changes. I think it should pass, but I am not sure why it is failing.

1) Failure:
test_not_analyzed_property(Mappings) [./test/mappings_test.rb:30]:
<1> expected but was
<0>.

@rubish
Copy link
Author

rubish commented May 10, 2011

Accidently added activerecord commit to this one. Was trying to remove the commit from pull request but instead created a pull request. Closing this one in favor of #15

@rubish rubish closed this May 10, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant